Skip to content

Revert "Improve listing performance of Hudi tables" on release-0.272#17706

Merged
varungajjala merged 1 commit intoprestodb:release-0.272from
mshang816:release-0.272-hotfix-scuba
Apr 28, 2022
Merged

Revert "Improve listing performance of Hudi tables" on release-0.272#17706
varungajjala merged 1 commit intoprestodb:release-0.272from
mshang816:release-0.272-hotfix-scuba

Conversation

@mshang816
Copy link
Copy Markdown
Contributor

This reverts commit ef1fd25.

Test plan - (Please fill in how you tested your changes)

Please make sure your submission complies with our Development, Formatting, and Commit Message guidelines. Don't forget to follow our attribution guidelines for any code copied from other projects.

Fill in the release notes towards the bottom of the PR description.
See Release Notes Guidelines for details.

== RELEASE NOTES ==

General Changes
* ...
* ...

Hive Changes
* ...
* ...

If release note is NOT required, use:

== NO RELEASE NOTE ==

@mshang816 mshang816 changed the title Revert "Improve listing performance of Hudi tables" Revert "Improve listing performance of Hudi tables" on release-0.272 Apr 28, 2022
@varungajjala varungajjala merged commit 0d5c245 into prestodb:release-0.272 Apr 28, 2022
@ankushChatterjee
Copy link
Copy Markdown

why is this revert being made?

@codope
Copy link
Copy Markdown
Contributor

codope commented Apr 30, 2022

@mshang816 @varungajjala This revert affects many Hudi users. May I know why this was done? Recommendations for shading and keeping hudi-presto-bundle thin were already taken care of in #17244
cc @arunthirupathi

@arunthirupathi
Copy link
Copy Markdown

@codope this is done just a hotfix for 0.272 release and not merged in master. It broke one of the connectors. so Hudi users are unaffected, unless they pick up this very specific build. I will follow up next week.

@codope
Copy link
Copy Markdown
Contributor

codope commented Apr 30, 2022

Thanks for the update @arunthirupathi

@ankushChatterjee
Copy link
Copy Markdown

Hi @arunthirupathi what connector was the change breaking?

@rohanpednekar
Copy link
Copy Markdown
Contributor

@arunthirupathi Could you please provide more guidance on this PR?

@arunthirupathi
Copy link
Copy Markdown

arunthirupathi commented May 3, 2022

To unblock 0.272 release (which was stuck for a month and half). The problem is already addressed for 0.273.

so there will be no revert in 0.273 and in master.

Let me know if you need more information or do you still see issues with the plan.

@umehrot2
Copy link
Copy Markdown

umehrot2 commented May 3, 2022

@arunthirupathi can you please point us to the actual fix in 0.273 ? We want to use 0.272, but at the same time want this patch. If you can point to what the issue/fix was, that would be really helpful.

@arunthirupathi
Copy link
Copy Markdown

It was an internal connector and the connector was internally modified for the next release, does starting a release for the next version help ?

@umehrot2
Copy link
Copy Markdown

umehrot2 commented May 3, 2022

When you say internal connector, do you mean something internal to facebook ? If that is the case, then for us at Amazon EMR we can just not include this revert patch while building our 0.272 internally. If it does not affect any open source Presto functionality, we should be okay to not include this patch for us internally. We just want that confirmation.

@arunthirupathi
Copy link
Copy Markdown

The connector was internal to facebook(Meta). So reverting this patch for Amazon EMR makes sense.

@umehrot2
Copy link
Copy Markdown

umehrot2 commented May 3, 2022

Thanks @arunthirupathi for the confirmation !

@dwshmilyss
Copy link
Copy Markdown

why does not merge this commit to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants