Use same operator type for index join builders#17630
Merged
highker merged 1 commit intoprestodb:masterfrom Apr 26, 2022
Merged
Conversation
...o-main/src/main/java/com/facebook/presto/operator/index/IndexBuildDriverFactoryProvider.java
Outdated
Show resolved
Hide resolved
Contributor
|
Please squash the commits. One commit is good for this PR |
NikhilCollooru
approved these changes
Apr 21, 2022
Contributor
NikhilCollooru
left a comment
NikhilCollooru
left a comment
There was a problem hiding this comment.
The PR looks good if the commits can be squashed into one.
v-jizhang
force-pushed
the
operator_type
branch
from
8f05922 to
1f4d4bd
Compare
highker
approved these changes
Apr 23, 2022
There was a problem hiding this comment.
Move this to the top of the stack. Break a line between static and non-static members.
Cherry-pick of trinodb/trino#11758 This prevents failures when adding operator stats (operators at same pipeline index should have same type). Co-authored-by: Karol Sobczak <napewnotrafi@gmail.com>
v-jizhang
force-pushed
the
operator_type
branch
from
429da57 to
2274141
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of trinodb/trino#11758
This prevents failures when adding operator stats
(operators at same pipeline index should have same type).
Co-authored-by: Karol Sobczak napewnotrafi@gmail.com
Test plan - Make sure CI tests pass