Fix minor bugs on querying Hudi MOR tables#17477
Fix minor bugs on querying Hudi MOR tables#17477arunthirupathi merged 1 commit intoprestodb:masterfrom
Conversation
|
@codope @pratyakshsharma Hi, would you like to take a review on this bugfix? |
Sure. I will do that. |
|
rerun the test |
|
@codope I haved added the tests. Could you take a second review? |
| @Override | ||
| public String getScheme() | ||
| { | ||
| return fs.getScheme(); |
There was a problem hiding this comment.
If we dont fix this method, MOR tables could not be queried. I added the intergration tests in #17463.
Following is part of the error messages:
Caused by: java.lang.UnsupportedOperationException: Not implemented by the HadoopExtendedFileSystem FileSystem implementation
at org.apache.hadoop.fs.FileSystem.getScheme(FileSystem.java:219)
at org.apache.hudi.common.fs.FSUtils.isGCSFileSystem(FSUtils.java:592)
at org.apache.hudi.common.table.log.HoodieLogFileReader.getFSDataInputStream(HoodieLogFileReader.java:119)
at org.apache.hudi.common.table.log.HoodieLogFileReader.(HoodieLogFileReader.java:95)
at org.apache.hudi.common.table.log.HoodieLogFileReader.(HoodieLogFileReader.java:86)
at org.apache.hudi.common.table.log.HoodieLogFormat.newReader(HoodieLogFormat.java:282)
at org.apache.hudi.common.table.log.LogReaderUtils.readSchemaFromLogFileInReverse(LogReaderUtils.java:49)
at org.apache.hudi.common.table.log.LogReaderUtils.readLatestSchemaFromLogFiles(LogReaderUtils.java:77)
at org.apache.hudi.hadoop.realtime.AbstractRealtimeRecordReader.init(AbstractRealtimeRecordReader.java:85)
at org.apache.hudi.hadoop.realtime.AbstractRealtimeRecordReader.(AbstractRealtimeRecordReader.java:67)
at org.apache.hudi.hadoop.realtime.RealtimeCompactedRecordReader.(RealtimeCompactedRecordReader.java:62)
at org.apache.hudi.hadoop.realtime.HoodieRealtimeRecordReader.constructRecordReader(HoodieRealtimeRecordReader.java:70)
at org.apache.hudi.hadoop.realtime.HoodieRealtimeRecordReader.(HoodieRealtimeRecordReader.java:47)
at org.apache.hudi.hadoop.realtime.HoodieParquetRealtimeInputFormat.getRecordReader(HoodieParquetRealtimeInputFormat.java:323)
at com.facebook.presto.hive.HiveUtil.createRecordReader(HiveUtil.java:272)
at com.facebook.presto.hive.GenericHiveRecordCursorProvider.lambda$createRecordCursor$0(GenericHiveRecordCursorProvider.java:74)
at com.facebook.presto.hive.authentication.NoHdfsAuthentication.doAs(NoHdfsAuthentication.java:23)
at com.facebook.presto.hive.HdfsEnvironment.doAs(HdfsEnvironment.java:81)
at com.facebook.presto.hive.GenericHiveRecordCursorProvider.createRecordCursor(GenericHiveRecordCursorProvider.java:73)
at com.facebook.presto.hive.HivePageSourceProvider.getPageSourceFromCursorProvider(HivePageSourceProvider.java:571)
You can check the full error log at https://github.com/prestodb/presto/runs/5566744421?check_suite_focus=true.
|
@arunthirupathi Could you please take a quick pass? Would be good to have it in the upcoming release. |
|
@arunthirupathi I have updated the description. |
This PR fixed two minor bugs on querying Hudi MOR tables.
It is extracted from #17463.
Test plan - Unit tests.