Spelling by jsoref · Pull Request #17393 · prestodb/presto

jsoref · 2022-03-03T12:46:23Z

Test plan

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@f42e814#commitcomment-67876501

The action reports that the changes in this PR would make it happy: jsoref@4a11b58

A bunch of things failed, but it looked like GitHub CI was broken overnight. I don't expect this to be merged as-is.

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.

Please make sure your submission complies with our Development, Formatting, and Commit Message guidelines. Don't forget to follow our attribution guidelines for any code copied from other projects.

Fill in the release notes towards the bottom of the PR description.
See Release Notes Guidelines for details.

== RELEASE NOTES ==

MongoDB Connector Changes
* Fix the spelling of the write concern option ``JOURNAL_SAFE`` for the property ``mongodb.write-concern``.

jsoref

Most corrections were automatically suggested by Google Sheets.
The doubling fixes were by me in a slightly more targeted manner, but I did try to skip the @param cases. I'll drop the ones I've flagged here.

I'm happy to drop anything as directed/split/etc.

jsoref · 2022-03-03T12:57:05Z

CONTRIBUTING.md


 Each pull request submission will be reviewed by a contributor or [committer](https://github.com/prestodb/presto/wiki/committers) 
-in the project. Only committers may merge a pull request. Large contributions should have an associated Github issue.
+in the project. Only committers may merge a pull request. Large contributions should have an associated GitHub issue.


This is a brand. (It's flagged by recently added tooling.)

jsoref · 2022-03-03T12:57:19Z

README.md

-The Presto Web UI is composed of several React components and is written in JSX and ES6. This source code is compiled and packaged into browser-compatible Javascript, which is then checked in to the Presto source code (in the `dist` folder). You must have [Node.js](https://nodejs.org/en/download/) and [Yarn](https://yarnpkg.com/en/) installed to execute these commands. To update this folder after making changes, simply run:
+The Presto Web UI is composed of several React components and is written in JSX and ES6. This source code is compiled and packaged into browser-compatible JavaScript, which is then checked in to the Presto source code (in the `dist` folder). You must have [Node.js](https://nodejs.org/en/download/) and [Yarn](https://yarnpkg.com/en/) installed to execute these commands. To update this folder after making changes, simply run:

    yarn --cwd presto-main/src/main/resources/webapp/src install

-If no Javascript dependencies have changed (i.e., no changes to `package.json`), it is faster to run:
+If no JavaScript dependencies have changed (i.e., no changes to `package.json`), it is faster to run:


Also a brand.

jsoref · 2022-03-03T12:57:49Z

mvnw

 fi

-# For Migwn, ensure paths are in UNIX format before anything is touched
+# For Mingw, ensure paths are in UNIX format before anything is touched


Also a brand (but, not flagged by the same tooling, this was just caught by the fact that it isn't in the dictionary).

jsoref · 2022-03-03T12:58:18Z

presto-accumulo/src/main/java/com/facebook/presto/accumulo/AccumuloModule.java

 * Presto module to do all kinds of run Guice injection stuff!
 * <p>
- * WARNING: Contains black magick
+ * WARNING: Contains black magic


Some projects are intentionally cute, this one doesn't appear to be particularly.

presto-accumulo/src/main/java/com/facebook/presto/accumulo/index/IndexLookup.java

jsoref · 2022-03-03T13:31:27Z

presto-main/src/test/java/com/facebook/presto/sql/planner/assertions/AggregationMatcher.java

                .add("preGroupedSymbols", preGroupedSymbols)
                .add("masks", masks)
-                .add("groudId", groupId)
+                .add("groupId", groupId)


presto-mongodb/src/main/java/com/facebook/presto/mongodb/WriteConcernType.java

presto-product-tests/src/main/resources/com/facebook/presto/tests/cli/batch_query.results

jsoref · 2022-03-03T13:33:39Z

presto-raptor/src/main/java/com/facebook/presto/raptor/storage/BucketBalancer.java

 * </ol>
 * <p> This prioritizes query performance over total cluster storage capacity, and therefore may
- * produce a cluster state that is imbalanced in terms of disk utilization.
+ * produce a cluster state that is uneven in terms of disk utilization.


Notable change

jsoref · 2022-03-03T13:34:46Z

presto-tests/src/main/java/com/facebook/presto/tests/AbstractTestQueries.java

        // Until we migrate all connectors to parametrized varchar we check two options
        assertTrue(actual.equals(expectedParametrizedVarchar) || actual.equals(expectedUnparametrizedVarchar),
-                format("%s does not matche neither of %s and %s", actual, expectedParametrizedVarchar, expectedUnparametrizedVarchar));
+                format("%s matches neither %s nor %s", actual, expectedParametrizedVarchar, expectedUnparametrizedVarchar));


rschlussel

This is awesome. Can you also update the commit messages to say" Fix Spelling: ..." instead of just "Spelling ..." to match our commit guidelines https://github.com/prestodb/presto/wiki/Review-and-Commit-guidelines#commit-formatting-and-pull-requests.

presto-main/src/test/java/com/facebook/presto/operator/aggregation/TestHistogram.java

presto-main/src/test/java/com/facebook/presto/sql/planner/TestRowExpressionFormatter.java

presto-accumulo/src/main/java/com/facebook/presto/accumulo/index/IndexLookup.java

rschlussel · 2022-03-03T17:50:14Z

...theus/src/test/java/com/facebook/presto/plugin/prometheus/TestPrometheusConnectorConfig.java

curious about the changes to add "example". Is that to avoid accidentally creating a real uri?

Yes, if you don't own a domain you shouldn't use it. example is allowed per DNS RFCs.

doesnotmatter.com is a real domain backed by real web servers and people shouldn't compose URLs that might go to things they don't control.

There are a number of examples of various major vendors (and individuals) messing up the internet in scary ways because they included strings and didn't realize that users might actually use the things. (A number of the examples are from Microsoft, but plenty aren't.)

rschlussel · 2022-03-03T17:51:18Z

presto-docs/src/main/sphinx/security/built-in-system-access-control.rst

    }

-If you want to allow users to use the extractly same name as their Kerberos principal
+If you want to allow users to use exactly same name as their Kerberos principal


should be "exactly the same name" (add the)

rschlussel · 2022-03-04T15:10:01Z

...o-main/src/main/java/com/facebook/presto/connector/system/jdbc/ProcedureColumnJdbcTable.java

    public static final ConnectorTableMetadata METADATA = tableMetadataBuilder(NAME)
            .column("procedure_cat", createUnboundedVarcharType())
-            .column("procedure_schem", createUnboundedVarcharType())
+            .column("procedure_schema", createUnboundedVarcharType())


Can you pull this change out? it needs a release note since it's a column name in a table we expose. I also want to double check whether there's anything else we need to do to make this change.

presto-main/src/main/java/com/facebook/presto/connector/system/jdbc/ProcedureJdbcTable.java

presto-mongodb/src/main/java/com/facebook/presto/mongodb/WriteConcernType.java

presto-docs/src/main/sphinx/connector/mongodb.rst

...metastore/src/main/java/com/facebook/presto/hive/metastore/alluxio/AlluxioHiveMetastore.java

rschlussel

One last thing

presto-benchto-benchmarks/src/main/resources/sql/presto/tpcds/q44.sql

presto-benchto-benchmarks/src/main/resources/sql/presto/tpcds/q63.sql

rschlussel · 2022-03-07T16:50:15Z

presto-main/src/main/java/com/facebook/presto/sql/planner/EqualityInference.java

-        public Iterable<RowExpression> nonInferrableConjuncts(RowExpression expression)
+        public Iterable<RowExpression> nonInferableConjuncts(RowExpression expression)
        {
            return filter(extractConjuncts(expression), not(isInferenceCandidate()));
        }

-        public static Iterable<RowExpression> nonInferrableConjuncts(Metadata metadata, RowExpression expression)
+        public static Iterable<RowExpression> nonInferableConjuncts(Metadata metadata, RowExpression expression)


thanks. this is not an api

Includes some minor grammatical fixes as well. Notable change: `JOURNAL_SAFEY` -> `JOURNAL_SAFE` Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

jsoref commented Mar 3, 2022

View reviewed changes

jsoref force-pushed the spelling branch 3 times, most recently from b8ddb61 to 6ff65c7 Compare March 3, 2022 16:46

rschlussel reviewed Mar 4, 2022

View reviewed changes

jsoref force-pushed the spelling branch from 6ff65c7 to d637440 Compare March 4, 2022 19:23

rschlussel reviewed Mar 7, 2022

View reviewed changes

Fix spelling

ef12166

Includes some minor grammatical fixes as well. Notable change: `JOURNAL_SAFEY` -> `JOURNAL_SAFE` Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

jsoref force-pushed the spelling branch from d637440 to ef12166 Compare March 7, 2022 17:39

rschlussel approved these changes Mar 7, 2022

View reviewed changes

rschlussel merged commit 5c6efc7 into prestodb:master Mar 7, 2022

jsoref deleted the spelling branch March 7, 2022 19:12

varungajjala mentioned this pull request Mar 22, 2022

Add release notes for 0.272 #17499

Closed

9 tasks

asjadsyed mentioned this pull request Mar 23, 2022

Add release notes for 0.272 #17510

Closed

9 tasks

asjadsyed mentioned this pull request Apr 1, 2022

Add release notes for 0.272 #17564

Merged

8 tasks

Conversation

jsoref commented Mar 3, 2022 • edited by rschlussel Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsoref left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rschlussel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rschlussel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jsoref commented Mar 3, 2022 •

edited by rschlussel

Loading