Skip to content

Thriftify ServerInfo#17391

Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom
SergeySmirnov:ThriftifyServerInfo
Mar 5, 2022
Merged

Thriftify ServerInfo#17391
tdcmeehan merged 1 commit intoprestodb:masterfrom
SergeySmirnov:ThriftifyServerInfo

Conversation

@SergeySmirnov
Copy link
Copy Markdown
Contributor

  • added Thrift serde support for ServerInfo
  • added thrift serialization unit tests

Ran tests locally: All Passed

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Mar 2, 2022

CLA Signed

The committers are authorized under a signed CLA.

  • ✅ Sergey Smirnov (bf458248d6c574410a0104848e05c2635a438ece, ca96fda0250e8242f03f66a79077925f66bec077, e1edf524dbc1b258e2496343bb7994faf24deae2, fa2c4d273219c0183ff30d88391b0940e524ee5c)

@ajaygeorge
Copy link
Copy Markdown
Contributor

Please clean up the commit message as well. Check out https://cbea.ms/git-commit/

@SergeySmirnov SergeySmirnov force-pushed the ThriftifyServerInfo branch 2 times, most recently from 0c27141 to 40bf6a2 Compare March 3, 2022 00:56
Copy link
Copy Markdown
Contributor

@ajaygeorge ajaygeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajaygeorge ajaygeorge requested a review from tdcmeehan March 3, 2022 01:17
@tdcmeehan tdcmeehan self-assigned this Mar 3, 2022
@tdcmeehan tdcmeehan merged commit ba99b74 into prestodb:master Mar 5, 2022
@varungajjala varungajjala mentioned this pull request Mar 22, 2022
9 tasks
@asjadsyed asjadsyed mentioned this pull request Mar 23, 2022
9 tasks
@asjadsyed asjadsyed mentioned this pull request Apr 1, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants