Wrapper the input and output stream of HadoopExtendedFileSystem#17365
Merged
highker merged 1 commit intoprestodb:masterfrom Mar 4, 2022
Merged
Wrapper the input and output stream of HadoopExtendedFileSystem#17365highker merged 1 commit intoprestodb:masterfrom
highker merged 1 commit intoprestodb:masterfrom
Conversation
|
|
gjhkael
force-pushed
the
fileSystemCacheBug
branch
from
71396d0 to
574a10a
Compare
7c00
reviewed
Feb 28, 2022
presto-hive-common/src/main/java/org/apache/hadoop/fs/HadoopExtendedFileSystem.java
Outdated
Show resolved
Hide resolved
gjhkael
force-pushed
the
fileSystemCacheBug
branch
from
574a10a to
8fdbe6a
Compare
Contributor
|
The test failures seem to be related. Should we just create a wrapper class for |
Contributor
|
Hey I am wondering if we need two commits for this change? |
Contributor
Author
|
I will rebase it |
gjhkael
force-pushed
the
fileSystemCacheBug
branch
from
555265b to
05054b5
Compare
Contributor
Author
|
@jainxrohit Please review the code |
Contributor
|
Overall looks good to me. Can you please specify what kind of testing you did? I would also prefer to have it as following |
gjhkael
changed the title
gjhkael
changed the title
highker
approved these changes
Mar 4, 2022
9 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the 'open' 'create' and 'append' api of HadoopExtendedFileSystem do not use Wrapper class to holds the FileSystem's reference, it will lead to FileSystem that cached in PrestoFileSystemCache closed by FinalizerService even it actually using in somewhere.
issue-17356