Throw proper error code when timezone is invalid from packDateTimeWit…#17363
Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom Mar 3, 2022
Merged
Throw proper error code when timezone is invalid from packDateTimeWit…#17363tdcmeehan merged 1 commit intoprestodb:masterfrom
tdcmeehan merged 1 commit intoprestodb:masterfrom
Conversation
amitkdutta
force-pushed
the
timezone_fix2
branch
from
e066cb6 to
968be88
Compare
amitkdutta
force-pushed
the
timezone_fix2
branch
from
968be88 to
ac2c8c1
Compare
tdcmeehan
approved these changes
Feb 28, 2022
9 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During packDateTimeWithZone execution, if an invalid timezone is passed as parameter, we should throw NOT_SUPPORTED error code. Currently this exception is not handled, which eventually throws GENERIC_INTERNAL_ERROR. Previously we handled such cases here: #17241 however it a few more places need to have try catch and throw proper exception.