Fix build failures caused by new method in HiveMetastore interface#17343
Merged
beinan merged 1 commit intoprestodb:masterfrom Feb 23, 2022
Merged
Fix build failures caused by new method in HiveMetastore interface#17343beinan merged 1 commit intoprestodb:masterfrom
beinan merged 1 commit intoprestodb:masterfrom
Conversation
Member
Author
|
hello @abhiseksaikia , as you suggested I just added the default impl into HiveMetastore which would fix the build. Just let me know if you saw any other failures in your build. Sorry for the inconvenience caused. |
Contributor
|
@beinan Thank you so much for the quick fix! |
ChunxuTang
approved these changes
Feb 23, 2022
Member
ChunxuTang
left a comment
ChunxuTang
left a comment
There was a problem hiding this comment.
LGTM. @beinan Thanks for your quick fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the build failure in FB caused by this PR. #16983