Fix build failures by remove junit deps in presto-parquet module#17334
Merged
zhenxiao merged 1 commit intoprestodb:masterfrom Feb 23, 2022
Merged
Fix build failures by remove junit deps in presto-parquet module#17334zhenxiao merged 1 commit intoprestodb:masterfrom
zhenxiao merged 1 commit intoprestodb:masterfrom
Conversation
beinan
force-pushed
the
fix_build_parquet_junit
branch
3 times, most recently
from
1d77580 to
3c3b900
Compare
beinan
changed the title
beinan
force-pushed
the
fix_build_parquet_junit
branch
from
3c3b900 to
a531566
Compare
Collaborator
|
LGTM |
zhenxiao
approved these changes
Feb 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using testng instead of junit to fix the error below in FB's build
[ERROR] Failed to execute goal on project presto-parquet: Could not resolve dependencies for project com.facebook.presto:presto-parquet:jar:0.272-SNAPSHOT: Failed to collect dependencies at junit:junit:jar:4.13.1: Failed to read artifact descriptor for junit:junit:jar:4.13.1: Could not transfer artifact junit:junit:pom:4.13.1 from/to nexus (https://maven.thefacebook.com/nexus/content/groups/public): Transfer failed for https://maven.thefacebook.com/nexus/content/groups/public/junit/junit/4.13.1/junit-4.13.1.pom: No route to host (Host unreachable) -> [Help 1]