Skip to content

Avoid volatile writes for empty responses in PageBufferClient #17318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pettyjamesm merged 1 commit into from
Feb 17, 2022
Merged

Avoid volatile writes for empty responses in PageBufferClient #17318

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions presto-main/src/main/java/com/facebook/presto/operator/PageBufferClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,7 @@ public void onSuccess(PagesResponse result)
backoff.success();

List<SerializedPage> pages;
boolean pagesAccepted;
try {
boolean shouldAcknowledge = false;
synchronized (PageBufferClient.this) {
Expand Down Expand Up @@ -324,20 +325,28 @@ public void onSuccess(PagesResponse result)
// clientCallback can keep stats of requests and responses. For example, it may
// keep track of how often a client returns empty response and adjust request
// frequency or buffer size.
if (clientCallback.addPages(PageBufferClient.this, pages)) {
pagesReceived.addAndGet(pages.size());
rowsReceived.addAndGet(pages.stream().mapToLong(SerializedPage::getPositionCount).sum());
}
else {
pagesRejected.addAndGet(pages.size());
rowsRejected.addAndGet(pages.stream().mapToLong(SerializedPage::getPositionCount).sum());
}
pagesAccepted = clientCallback.addPages(PageBufferClient.this, pages);
}
catch (PrestoException e) {
handleFailure(e, resultFuture);
return;
}

// update client stats
if (!pages.isEmpty()) {
int pageCount = pages.size();
long rowCount = pages.stream().mapToLong(SerializedPage::getPositionCount).sum();
if (pagesAccepted) {
pagesReceived.addAndGet(pageCount);
rowsReceived.addAndGet(rowCount);
}
else {
pagesRejected.addAndGet(pageCount);
rowsRejected.addAndGet(rowCount);
}
}
requestsCompleted.incrementAndGet();

synchronized (PageBufferClient.this) {
// client is complete, acknowledge it by sending it a delete in the next request
if (result.isClientComplete()) {
Expand All @@ -348,7 +357,6 @@ public void onSuccess(PagesResponse result)
}
lastUpdate = DateTime.now();
}
requestsCompleted.incrementAndGet();
clientCallback.requestComplete(PageBufferClient.this);
}

Expand Down