Only collect stats for primitive types in ThriftHiveMetastore#17268
Only collect stats for primitive types in ThriftHiveMetastore#17268rschlussel merged 1 commit intoprestodb:masterfrom
Conversation
|
1 similar comment
|
rschlussel
left a comment
There was a problem hiding this comment.
Thank you for working on this! Can you add a unit test for partitioned tables to TestHiveTableStatistics for a partitioned table with non-primitive types?
There was a problem hiding this comment.
I would inline the function here instead of adding it to Util since it's not used anywhere else.
|
Also, please make sure to sign the CLA |
|
One more thing:
|
getSupportedColumnStatistics for ThriftHiveMetastore ignorin…|
Thanks @rschlussel for reviewing this. I have force pushed a new version of the commit, where all the comments are addressed. |
|
Thank you! |
Fixes #16693
Test plan - (Please fill in how you tested your changes)
ANALYZE TABLEon Hive tables reads raw data proportional only to columns with primitive typesANALYZE TABLEworks for both partitioned and un-partitioned hive tables with complex columns