Support ORC format caching for iceberg connector#17262
Merged
beinan merged 1 commit intoprestodb:masterfrom Feb 10, 2022
Merged
Support ORC format caching for iceberg connector#17262beinan merged 1 commit intoprestodb:masterfrom
beinan merged 1 commit intoprestodb:masterfrom
Conversation
rongrong
reviewed
Feb 8, 2022
Contributor
rongrong
left a comment
rongrong
left a comment
There was a problem hiding this comment.
Thanks for working on this. Only some small improvements.
presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergPageSourceProvider.java
Outdated
Show resolved
Hide resolved
presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergPageSourceProvider.java
Outdated
Show resolved
Hide resolved
Contributor
|
Please squash all commits into one and force push to update the branch. |
JySongWithZhangCe
deleted the
support_orc_caching_for_iceberg_connector
branch
JySongWithZhangCe
restored the
support_orc_caching_for_iceberg_connector
branch
Support ORC format caching for iceberg connector fix code style Support ORC format caching for iceberg connector
JySongWithZhangCe
force-pushed
the
support_orc_caching_for_iceberg_connector
branch
from
b4e6456 to
3d4c4b2
Compare
Contributor
Author
Done |
rongrong
approved these changes
Feb 9, 2022
Member
|
Hi @JySongWithZhangCe, thanks for your contribution! instead of == RELEASE NOTES ==
|
Contributor
Author
Done, thx @beinan |
This was referenced Feb 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #17261