Skip to content

Add Prepared statement sql to query lifecycle events#17258

Merged
rschlussel merged 1 commit intoprestodb:masterfrom
ShashwatArghode:features
Feb 16, 2022
Merged

Add Prepared statement sql to query lifecycle events#17258
rschlussel merged 1 commit intoprestodb:masterfrom
ShashwatArghode:features

Conversation

@ShashwatArghode
Copy link
Copy Markdown
Contributor

This commit is a port of the following commits:
trinodb/trino@484d421
trinodb/trino@0a10c47
trinodb/trino@79f67a1

Test plan - (Please fill in how you tested your changes)

  1. Verified Presto UI shows expanded prepared query without disturbing other UI semantics.
  2. Added unit test cases.
== RELEASE NOTES ==

General Changes
* Add support for viewing expanded prepared query in Web UI.

@ShashwatArghode
Copy link
Copy Markdown
Contributor Author

UI Screenshot after the changes:
Screen Shot 2022-02-04 at 9 35 58 AM

Copy link
Copy Markdown
Contributor

@rschlussel rschlussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Copy link
Copy Markdown
Contributor

@rschlussel rschlussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more thing

Copy link
Copy Markdown
Contributor

@rschlussel rschlussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! will merge once the tests pass

@ShashwatArghode
Copy link
Copy Markdown
Contributor Author

Resolved conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants