Adding checkArgument function to properly throw Presto Exception when…#17245
Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom Feb 4, 2022
Merged
Adding checkArgument function to properly throw Presto Exception when…#17245tdcmeehan merged 1 commit intoprestodb:masterfrom
tdcmeehan merged 1 commit intoprestodb:masterfrom
Conversation
amitkdutta
force-pushed
the
checkargument_fix
branch
from
3029e66 to
24662e3
Compare
tdcmeehan
reviewed
Feb 1, 2022
...main/src/main/java/com/facebook/presto/sql/planner/sanity/ValidateStreamingAggregations.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/tdigest/TDigest.java
Outdated
Show resolved
Hide resolved
presto-main/src/test/java/com/facebook/presto/tdigest/TestTDigest.java
Outdated
Show resolved
Hide resolved
amitkdutta
force-pushed
the
checkargument_fix
branch
3 times, most recently
from
09e794b to
8a2e2b7
Compare
tdcmeehan
reviewed
Feb 3, 2022
presto-main/src/main/java/com/facebook/presto/tdigest/TDigest.java
Outdated
Show resolved
Hide resolved
amitkdutta
force-pushed
the
checkargument_fix
branch
from
8a2e2b7 to
8a3695b
Compare
tdcmeehan
approved these changes
Feb 3, 2022
… argument is invalid.
amitkdutta
force-pushed
the
checkargument_fix
branch
from
8a3695b to
6308cea
Compare
This was referenced Feb 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In many parts of the codebase, we use checkArgument to check argument validity. checkArgument throws IllegalArgument exception, which is not wrapped in PrestoException and error code. We add a checkArgument class in this PR that throws PrestoException with proper error code, instead of using google's checkArgument.