Follow the SQL standard in cast from double or real to varchar#17232
Merged
zhenxiao merged 5 commits intoprestodb:masterfrom Mar 2, 2022
Merged
Follow the SQL standard in cast from double or real to varchar#17232zhenxiao merged 5 commits intoprestodb:masterfrom
zhenxiao merged 5 commits intoprestodb:masterfrom
Conversation
v-jizhang
force-pushed
the
cast-double-real-to-varchar
branch
from
101bfdc to
abf4768
Compare
Collaborator
|
@v-jizhang could you please rebase? I will take a look |
Cherry-pick of trinodb/trino@631a958 This change applies to double and real Co-authored-by: kasiafi <30203062+kasiafi@users.noreply.github.com>
Cherry-pick of trinodb/trino@32c92b0 Fix cast from double to varchar: do not return values overflowing the type. Co-authored-by: kasiafi <30203062+kasiafi@users.noreply.github.com>
Cherry-pick of trinodb/trino@1eed22a Co-authored-by: kasiafi <30203062+kasiafi@users.noreply.github.com>
Cherry-pick of trinodb/trino@1420a67 Co-authored-by: kasiafi <30203062+kasiafi@users.noreply.github.com>
v-jizhang
force-pushed
the
cast-double-real-to-varchar
branch
from
abf4768 to
671efd6
Compare
Contributor
Author
|
@zhenxiao Done. Thanks |
zhenxiao
approved these changes
Mar 1, 2022
Collaborator
zhenxiao
left a comment
zhenxiao
left a comment
There was a problem hiding this comment.
looks nice @v-jizhang
one minor thing, could you please merge the style fix commit into previous commits?
Cherry-pick of trinodb/trino@ce125d0 Co-authored-by: kasiafi <30203062+kasiafi@users.noreply.github.com>
v-jizhang
force-pushed
the
cast-double-real-to-varchar
branch
from
3859f3d to
8461292
Compare
Contributor
Author
|
Squashed. Thanks @zhenxiao |
9 tasks
This was referenced Mar 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of trinodb/trino@631a958
This change applies to double and real
Co-authored-by: kasiafi 30203062+kasiafi@users.noreply.github.com
Test plan - Added tests