Parquet predicate improvements#17217
Merged
zhenxiao merged 2 commits intoprestodb:masterfrom Jan 25, 2022
Merged
Conversation
zhenxiao
force-pushed
the
parquet-predicate
branch
from
481afa4 to
bb41d23
Compare
vkorukanti
approved these changes
Jan 24, 2022
Contributor
vkorukanti
left a comment
vkorukanti
left a comment
There was a problem hiding this comment.
Minor comments. LGTM.
Contributor
There was a problem hiding this comment.
checkArgument(!rangeList.isEmpty(), "cannot use empty rangeList")
Contributor
There was a problem hiding this comment.
Doc would be good to understand what is expected of the arguments.
presto-hive/src/main/java/com/facebook/presto/hive/HiveClientConfig.java
Outdated
Show resolved
Hide resolved
...parquet/src/main/java/com/facebook/presto/parquet/predicate/TupleDomainParquetPredicate.java
Outdated
Show resolved
Hide resolved
...parquet/src/main/java/com/facebook/presto/parquet/predicate/TupleDomainParquetPredicate.java
Outdated
Show resolved
Hide resolved
...parquet/src/main/java/com/facebook/presto/parquet/predicate/TupleDomainParquetPredicate.java
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Are there any existing tests the test the code path TupleDomainParquetPredicate.getDomain(..) that pass multiple ranges to it?
zhenxiao
force-pushed
the
parquet-predicate
branch
from
bb41d23 to
77d7a77
Compare
Cherry-pick of trinodb/trino@fce0521 Co-authored-by: Martin Traverso <mtraverso@gmail.com>
…on corrupted parquet statistics
zhenxiao
force-pushed
the
parquet-predicate
branch
from
77d7a77 to
9d06742
Compare
4 tasks
|
Why remove this corrupted check？ |
Member
|
so what's the workaround when a SQL encountered a corrupted parquet stats without |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan - TestTupleDomainParquetPredicate