-
Notifications
You must be signed in to change notification settings - Fork 5.5k
[WIP] Improve Hudi table listing performance #17077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
118 changes: 118 additions & 0 deletions
118
presto-hive/src/main/java/com/facebook/presto/hive/HudiDirectoryLister.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,118 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.facebook.presto.hive; | ||
|
|
||
| import com.facebook.airlift.log.Logger; | ||
| import com.facebook.presto.hive.filesystem.ExtendedFileSystem; | ||
| import com.facebook.presto.hive.metastore.Table; | ||
| import com.facebook.presto.hive.util.HiveFileIterator; | ||
| import com.facebook.presto.spi.ConnectorSession; | ||
| import org.apache.hadoop.conf.Configuration; | ||
| import org.apache.hadoop.fs.BlockLocation; | ||
| import org.apache.hadoop.fs.FileStatus; | ||
| import org.apache.hadoop.fs.LocatedFileStatus; | ||
| import org.apache.hadoop.fs.Path; | ||
| import org.apache.hadoop.fs.PathFilter; | ||
| import org.apache.hadoop.fs.RemoteIterator; | ||
| import org.apache.hudi.common.config.HoodieMetadataConfig; | ||
| import org.apache.hudi.common.engine.HoodieEngineContext; | ||
| import org.apache.hudi.common.engine.HoodieLocalEngineContext; | ||
| import org.apache.hudi.common.fs.FSUtils; | ||
| import org.apache.hudi.common.model.HoodieBaseFile; | ||
| import org.apache.hudi.common.table.HoodieTableMetaClient; | ||
| import org.apache.hudi.common.table.view.FileSystemViewManager; | ||
| import org.apache.hudi.common.table.view.HoodieTableFileSystemView; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.Iterator; | ||
| import java.util.Optional; | ||
|
|
||
| import static com.facebook.presto.hive.HiveFileInfo.createHiveFileInfo; | ||
| import static com.facebook.presto.hive.HiveSessionProperties.isHudiPreferMetadataToListFiles; | ||
| import static org.apache.hadoop.hdfs.DFSConfigKeys.DFS_DATANODE_DEFAULT_PORT; | ||
|
|
||
| public final class HudiDirectoryLister | ||
| implements DirectoryLister | ||
| { | ||
| private static final Logger log = Logger.get(HudiDirectoryLister.class); | ||
|
|
||
| private final HoodieTableFileSystemView fileSystemView; | ||
|
|
||
| public HudiDirectoryLister(Configuration conf, ConnectorSession session, Table table) | ||
| { | ||
| log.info("Using Hudi Directory Lister."); | ||
| HoodieTableMetaClient metaClient = HoodieTableMetaClient.builder() | ||
| .setConf(conf) | ||
| .setBasePath(table.getStorage().getLocation()) | ||
| .build(); | ||
| HoodieEngineContext engineContext = new HoodieLocalEngineContext(conf); | ||
| HoodieMetadataConfig metadataConfig = HoodieMetadataConfig.newBuilder() | ||
| .enable(isHudiPreferMetadataToListFiles(session)) | ||
| .build(); | ||
| this.fileSystemView = FileSystemViewManager.createInMemoryFileSystemView(engineContext, metaClient, | ||
| metadataConfig); | ||
| } | ||
|
|
||
| @Override | ||
| public Iterator<HiveFileInfo> list(ExtendedFileSystem fileSystem, | ||
| Table table, | ||
| Path path, | ||
| NamenodeStats namenodeStats, | ||
| PathFilter pathFilter, | ||
| HiveDirectoryContext hiveDirectoryContext) | ||
| { | ||
| log.debug("Listing path using Hudi directory lister: %s", path.toString()); | ||
| return new HiveFileIterator( | ||
| path, | ||
| p -> new HudiFileInfoIterator(fileSystemView, fileSystem.listStatus(p), table.getStorage().getLocation(), p), | ||
| namenodeStats, | ||
| hiveDirectoryContext.getNestedDirectoryPolicy(), | ||
| Optional.empty()); | ||
| } | ||
|
|
||
| public static class HudiFileInfoIterator | ||
| implements RemoteIterator<HiveFileInfo> | ||
| { | ||
| private final Iterator<HoodieBaseFile> hoodieBaseFileIterator; | ||
|
|
||
| public HudiFileInfoIterator( | ||
| HoodieTableFileSystemView fileSystemView, | ||
| FileStatus[] fileStatuses, | ||
| String tablePath, | ||
| Path directory) | ||
| { | ||
| fileSystemView.addFilesToView(fileStatuses); | ||
| String partition = FSUtils.getRelativePartitionPath(new Path(tablePath), directory); | ||
| this.hoodieBaseFileIterator = fileSystemView.fetchLatestBaseFiles(partition).iterator(); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean hasNext() | ||
| { | ||
| return hoodieBaseFileIterator.hasNext(); | ||
| } | ||
|
|
||
| @Override | ||
| public HiveFileInfo next() | ||
| throws IOException | ||
| { | ||
| FileStatus fileStatus = hoodieBaseFileIterator.next().getFileStatus(); | ||
| String[] name = new String[] {"localhost:" + DFS_DATANODE_DEFAULT_PORT}; | ||
| String[] host = new String[] {"localhost"}; | ||
| LocatedFileStatus hoodieFileStatus = new LocatedFileStatus(fileStatus, | ||
| new BlockLocation[] {new BlockLocation(name, host, 0L, fileStatus.getLen())}); | ||
| return createHiveFileInfo(hoodieFileStatus, Optional.empty()); | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hive.hudi-enable-metadataThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have addressed this in #17084
Closing this draft patch as there were some more changes.