Skip to content

Optimize filter condition with switch case #17065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rschlussel merged 2 commits into from
May 12, 2022
Merged

Optimize filter condition with switch case #17065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
083baaf
Allow RowExpressionRewriteRuleSet to be enabled or disabled
maswin May 2, 2022
8c11aa4
Optimize filter condition with CASE predicate
maswin May 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 35 additions & 1 deletion presto-expressions/src/main/java/com/facebook/presto/expressions/LogicalRowExpressions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
import static com.facebook.presto.spi.relation.SpecialFormExpression.Form.AND;
import static com.facebook.presto.spi.relation.SpecialFormExpression.Form.IS_NULL;
import static com.facebook.presto.spi.relation.SpecialFormExpression.Form.OR;
import static com.facebook.presto.spi.relation.SpecialFormExpression.Form.SWITCH;
import static java.lang.Math.min;
import static java.util.Arrays.asList;
import static java.util.Arrays.stream;
Expand Down Expand Up @@ -631,6 +632,21 @@ private boolean isComparisonExpression(RowExpression expression)
return expression instanceof CallExpression && functionResolution.isComparisonFunction(((CallExpression) expression).getFunctionHandle());
}

public boolean isEqualsExpression(RowExpression expression)
{
return expression instanceof CallExpression && functionResolution.isEqualsFunction(((CallExpression) expression).getFunctionHandle());
}

public boolean isCastExpression(RowExpression expression)
{
return expression instanceof CallExpression && functionResolution.isCastFunction(((CallExpression) expression).getFunctionHandle());
}

public boolean isCaseExpression(RowExpression expression)
{
return expression instanceof SpecialFormExpression && ((SpecialFormExpression) expression).getForm().equals(SWITCH);
}

/**
* Extract the component predicates as a list of list in which is grouped so that the outer level has same conjunctive/disjunctive joiner as original predicate and
* inner level has opposite joiner.
Expand Down Expand Up @@ -771,11 +787,29 @@ private Optional<OperatorType> getOperator(RowExpression expression)
return Optional.empty();
}

private RowExpression notCallExpression(RowExpression argument)
public RowExpression notCallExpression(RowExpression argument)
{
return new CallExpression(argument.getSourceLocation(), "not", functionResolution.notFunction(), BOOLEAN, singletonList(argument));
}

public RowExpression equalsCallExpression(RowExpression left, RowExpression right)
{
return new CallExpression(
EQUAL.name(),
functionResolution.comparisonFunction(EQUAL, left.getType(), right.getType()),
BOOLEAN,
asList(left, right));
}

public static RowExpression replaceArguments(CallExpression expression, RowExpression... arguments)
{
return new CallExpression(
expression.getDisplayName(),
expression.getFunctionHandle(),
expression.getType(),
asList(arguments));
}

private static OperatorType negate(OperatorType operator)
{
switch (operator) {
Expand Down
11 changes: 11 additions & 0 deletions presto-main/src/main/java/com/facebook/presto/SystemSessionProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ public final class SystemSessionProperties
public static final String PARTIAL_AGGREGATION_STRATEGY = "partial_aggregation_strategy";
public static final String PARTIAL_AGGREGATION_BYTE_REDUCTION_THRESHOLD = "partial_aggregation_byte_reduction_threshold";
public static final String OPTIMIZE_TOP_N_ROW_NUMBER = "optimize_top_n_row_number";
public static final String OPTIMIZE_CASE_EXPRESSION_PREDICATE = "optimize_case_expression_predicate";
public static final String MAX_GROUPING_SETS = "max_grouping_sets";
public static final String LEGACY_UNNEST = "legacy_unnest";
public static final String STATISTICS_CPU_TIMER_ENABLED = "statistics_cpu_timer_enabled";
Expand Down Expand Up @@ -851,6 +852,11 @@ public SystemSessionProperties(
"Use top N row number optimization",
featuresConfig.isOptimizeTopNRowNumber(),
false),
booleanProperty(
OPTIMIZE_CASE_EXPRESSION_PREDICATE,
"Optimize case expression predicates",
featuresConfig.isOptimizeCaseExpressionPredicate(),
false),
integerProperty(
MAX_GROUPING_SETS,
"Maximum number of grouping sets in a GROUP BY",
Expand Down Expand Up @@ -1795,6 +1801,11 @@ public static boolean isOptimizeTopNRowNumber(Session session)
return session.getSystemProperty(OPTIMIZE_TOP_N_ROW_NUMBER, Boolean.class);
}

public static boolean isOptimizeCaseExpressionPredicate(Session session)
{
return session.getSystemProperty(OPTIMIZE_CASE_EXPRESSION_PREDICATE, Boolean.class);
}

public static boolean isDistributedSortEnabled(Session session)
{
return session.getSystemProperty(DISTRIBUTED_SORT, Boolean.class);
Expand Down
13 changes: 13 additions & 0 deletions presto-main/src/main/java/com/facebook/presto/sql/analyzer/FeaturesConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ public class FeaturesConfig
private int optimizeMetadataQueriesCallThreshold = 100;
private boolean optimizeHashGeneration = true;
private boolean enableIntermediateAggregations;
private boolean optimizeCaseExpressionPredicate;
private boolean pushTableWriteThroughUnion = true;
private boolean exchangeCompressionEnabled;
private boolean exchangeChecksumEnabled;
Expand Down Expand Up @@ -874,6 +875,18 @@ public FeaturesConfig setOptimizeTopNRowNumber(boolean optimizeTopNRowNumber)
return this;
}

public boolean isOptimizeCaseExpressionPredicate()
{
return optimizeCaseExpressionPredicate;
}

@Config("optimizer.optimize-case-expression-predicate")
public FeaturesConfig setOptimizeCaseExpressionPredicate(boolean optimizeCaseExpressionPredicate)
{
this.optimizeCaseExpressionPredicate = optimizeCaseExpressionPredicate;
return this;
}

public boolean isOptimizeHashGeneration()
{
return optimizeHashGeneration;
Expand Down
8 changes: 8 additions & 0 deletions presto-main/src/main/java/com/facebook/presto/sql/planner/PlanOptimizers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@
import com.facebook.presto.sql.planner.iterative.rule.RemoveUnsupportedDynamicFilters;
import com.facebook.presto.sql.planner.iterative.rule.ReorderJoins;
import com.facebook.presto.sql.planner.iterative.rule.RewriteAggregationIfToFilter;
import com.facebook.presto.sql.planner.iterative.rule.RewriteCaseExpressionPredicate;
import com.facebook.presto.sql.planner.iterative.rule.RewriteFilterWithExternalFunctionToProject;
import com.facebook.presto.sql.planner.iterative.rule.RewriteSpatialPartitioningAggregation;
import com.facebook.presto.sql.planner.iterative.rule.RuntimeReorderJoinSides;
Expand Down Expand Up @@ -277,6 +278,12 @@ public PlanOptimizers(
.add(new PruneRedundantProjectionAssignments())
.build());

IterativeOptimizer caseExpressionPredicateRewriter = new IterativeOptimizer(
ruleStats,
statsCalculator,
estimatedExchangesCostCalculator,
new RewriteCaseExpressionPredicate(metadata.getFunctionAndTypeManager()).rules());

PlanOptimizer predicatePushDown = new StatsRecordingPlanOptimizer(optimizerStats, new PredicatePushDown(metadata, sqlParser));

builder.add(
Expand Down Expand Up @@ -405,6 +412,7 @@ public PlanOptimizers(
// After this point, all planNodes should not contain OriginalExpression

builder.add(
caseExpressionPredicateRewriter,
new IterativeOptimizer(
ruleStats,
statsCalculator,
Expand Down
Loading