Fix: Iceberg Parquet writer sometimes fails with "Failed to read footer of file: io.prestosql.plugin.iceberg.HdfsInputFile"#16968
Merged
beinan merged 1 commit intoprestodb:masterfrom Nov 18, 2021
Conversation
liupan664021
force-pushed
the
fix-fail-footer-parquet
branch
from
d779814 to
fcf2655
Compare
Cherry-pick of trinodb/trino#8504 Co-authored-by: Pratham Desai <prathamd94@gmail.com>
liupan664021
force-pushed
the
fix-fail-footer-parquet
branch
from
fcf2655 to
9f5534c
Compare
Member
|
@ChunxuTang could you help take a look? looks like this one will fix the flaky iceberg tests, but I'm not sure if it's really an issue because the iceberg tests are working well mostly to me. |
Contributor
Author
Yep, this exception does not appear when running iceberg tests. We met this problem in our production enviroment, and the PR from trino looks quite reasonable and solve the problem quite well. So I pick it :) |
ChunxuTang
approved these changes
Nov 18, 2021
Member
ChunxuTang
left a comment
ChunxuTang
left a comment
There was a problem hiding this comment.
@liupan664021 Thanks for the work! LGTM.
beinan
approved these changes
Nov 18, 2021
Member
beinan
left a comment
beinan
left a comment
There was a problem hiding this comment.
Thank you for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of trinodb/trino#8504
Co-authored-by: Pratham Desai prathamd94@gmail.com
The PR fixes #16967 #16206