upgrading the parquet/avro version#16923
Conversation
|
@beinan , @shangxinli, Couple of Iceberg test failures now. Any ideas Failures: |
There was a problem hiding this comment.
@ugurmeet this change broke the iceberg test, I tried to change it back, then iceberg test looks ok. But looks like it would failed hive test, am I right?
There was a problem hiding this comment.
Ok, I think the root cause is the parquet version in the root pom of presto is still 1.11.0, and iceberg connector is using parquet version in the root pom somehow. @ugurmeet could you upgrade the parquet in the root pom of presto to 1.11.1? then the issue should be fixed. Thanks!
There was a problem hiding this comment.
Thanks a lot @beinan , all tests are passing now
There was a problem hiding this comment.
Thank you so much! You work unblocks a dozen of new features on hive and iceberg connector!
|
@ugurmeet could you change the release note part in the pr? Thanks! Also we cannot merge it until hive 3.0.0.7 is ready on public maven repo. |
|
Thanks @beinan . Updated the Release Notes. Waiting for the release 3.0.0-7 to be created. Will retest once the release jar is created. |
|
Hi @beinan, changed the use release 3.0.0-7. Let me know if anything else needs to be done. Thanks |
beinan
left a comment
There was a problem hiding this comment.
lgtm, @ugurmeet could squash the commits into one?
An example of the commit message:
Foo was pack ratting ByteBuffers causing OOM.
Cherry-pick of https://github.com/foo/bar/pull/123 (https://github.com/foo/bar/pull/123)
Co-authored-by: Foo Bar <foo@bar.com>
presto-hive-apache 3.0.0-7
e495f25 to
16b8b8b
Compare
|
Just a heads up the first line of the commit message was too long. It shouldn't wrap in the GH ui :-) |
Thank you for the reminding! I will take care next time! thanks! |
|
Thanks a lot @beinan, @aweisberg for help with debugging and pushing this through. |
Test plan -
Existing tests