Add filter check for JDBC pushdown unit tests#16864
Merged
highker merged 1 commit intoprestodb:masterfrom Oct 13, 2021
Merged
Conversation
highker
requested review from
NikhilCollooru,
arunthirupathi,
kewang1024,
tdcmeehan and
yuanzhanhku
JDBC filter pushdown always needs to preserve the original filter for correctness. This is to prevent regressions like prestodb#16412 where filters are partially pushed down and there is no guard on Presto side.
arunthirupathi
approved these changes
Oct 13, 2021
arunthirupathi
left a comment
arunthirupathi
left a comment
There was a problem hiding this comment.
Looks good.
There were unrelated resource manager tests failing.
yuanzhanhku
approved these changes
Oct 13, 2021
rongrong
reviewed
Oct 13, 2021
|
|
||
| // we always enforce the original filter to be present | ||
| // the following assertPlan will guarantee the completeness of the filter | ||
| if (node instanceof FilterNode && node.getSources().get(0) instanceof TableScanNode) { |
Contributor
There was a problem hiding this comment.
Is it possible to also check that the filter matches?
Author
There was a problem hiding this comment.
Ya, the filter match will be checked by the following assertPlan. As long as filterNode is present, it will check.
rongrong
approved these changes
Oct 13, 2021
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JDBC filter pushdown always needs to preserve the original filter for
correctness. This is to prevent regressions like #16412 where filters
are partially pushed down and there is no guard on Presto side.