Revert "Supports pushing down part of the filters when all filters cannot be pushed down"#16604
Merged
mbasmanova merged 1 commit intomasterfrom Aug 13, 2021
Merged
Conversation
This reverts commit 31266f5.
vaishnavibatni
requested review from
NikhilCollooru,
highker,
kaikalur,
rongrong and
tdcmeehan
NikhilCollooru
approved these changes
Aug 13, 2021
3 tasks
|
Hi @vaishnavibatni, I just researched the jdbc pushdown feature in pull request 16412# and 16570#, and found the pull request 16412# was merged to master and then was reverted. Could you explain what were the correctness errors? And I found 16570# was still awaiting-community-help for half a year. No changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverting #16412 because it's causing correctness errors.