Always create hive target directory if not present#16590
Merged
rschlussel merged 4 commits intoprestodb:masterfrom Aug 11, 2021
Merged
Always create hive target directory if not present#16590rschlussel merged 4 commits intoprestodb:masterfrom
rschlussel merged 4 commits intoprestodb:masterfrom
Conversation
rschlussel
force-pushed
the
fix-empty-bucketed-table
branch
2 times, most recently
from
e257f3b to
676cb7e
Compare
rschlussel
requested review from
NikhilCollooru,
aweisberg,
highker and
v-jizhang
highker
approved these changes
Aug 11, 2021
Contributor
Author
There was a problem hiding this comment.
was automatically reformatted by intellij. figured it was better to commit the autoformatting changes than fight with it all the time.
There was a problem hiding this comment.
maybe && directory.isDirectory() as well?
rschlussel
force-pushed
the
fix-empty-bucketed-table
branch
3 times, most recently
from
5781cf5 to
b7e15b7
Compare
prestodb#16456 broke creation of empty unpartitioned bucketed tables if they weren't using a temporary staging directory, as the target directory would not get created.
rschlussel
force-pushed
the
fix-empty-bucketed-table
branch
from
b7e15b7 to
ec0557e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#16456 broke creation of empty
unpartitioned bucketed tables if they weren't using a temporary staging
directory, as the target directory would not get created.
Test plan - Unit test