Skip to content

Set experimental.join-spill-enabled to true by default#16560

Merged
rschlussel merged 1 commit intoprestodb:masterfrom
rschlussel:join-spill-default
Aug 4, 2021
Merged

Set experimental.join-spill-enabled to true by default#16560
rschlussel merged 1 commit intoprestodb:masterfrom
rschlussel:join-spill-default

Conversation

@rschlussel
Copy link
Contributor

@rschlussel rschlussel commented Aug 4, 2021

This means that when spill_enabled is true, join spill will be enabled
without any additional settings. It was unintuitive that previously
enabling spill would turn it on for all operators other than join.

Test plan - unit test

== RELEASE NOTES ==

General Changes
* When spill is enabled, enable join spilling by default.  This can be disabled by setting the configuration property ``experimental.join-spill-enabled`` or session property ``join_spill_enabled`` to ``false``.

@rschlussel
Set experimental.join-spill-enabled to true by default
f82a0c3 
This means that when spill_enabled is true, join spill will be enabled
without any additional settings.  It was unintuitive that previously
enabling spill would turn it on for all operators other than join.
@rschlussel rschlussel requested a review from a team August 4, 2021 15:46
@arhimondr arhimondr requested a review from pgupta2 August 4, 2021 15:59
@rschlussel rschlussel merged commit 3127c28 into prestodb:master Aug 4, 2021
@varungajjala varungajjala mentioned this pull request Aug 16, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arhimondr arhimondr arhimondr approved these changes

@pgupta2 pgupta2 pgupta2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rschlussel @arhimondr @pgupta2