Skip to content

Enable verbose memory exceeded errors by default #16458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arhimondr merged 1 commit into from
Jul 22, 2021
Merged

Enable verbose memory exceeded errors by default #16458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion presto-main/src/main/java/com/facebook/presto/memory/NodeMemoryConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public class NodeMemoryConfig
private DataSize softMaxQueryTotalMemoryPerNode;
private DataSize heapHeadroom = new DataSize(AVAILABLE_HEAP_MEMORY * 0.3, BYTE);

private boolean verboseExceededMemoryLimitErrorsEnabled;
private boolean verboseExceededMemoryLimitErrorsEnabled = true;

@NotNull
public DataSize getMaxQueryBroadcastMemory()
Expand Down
10 changes: 5 additions & 5 deletions presto-main/src/test/java/com/facebook/presto/memory/TestNodeMemoryConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public void testDefaults()
.setSoftMaxQueryTotalMemoryPerNode(new DataSize(AVAILABLE_HEAP_MEMORY * 0.3, BYTE))
.setHeapHeadroom(new DataSize(AVAILABLE_HEAP_MEMORY * 0.3, BYTE))
.setReservedPoolEnabled(true)
.setVerboseExceededMemoryLimitErrorsEnabled(false));
.setVerboseExceededMemoryLimitErrorsEnabled(true));
}

@Test
Expand All @@ -54,7 +54,7 @@ public void testExplicitPropertyMappings()
.put("query.soft-max-total-memory-per-node", "2GB")
.put("memory.heap-headroom-per-node", "1GB")
.put("experimental.reserved-pool-enabled", "false")
.put("memory.verbose-exceeded-memory-limit-errors-enabled", "true")
.put("memory.verbose-exceeded-memory-limit-errors-enabled", "false")
.build();

NodeMemoryConfig expected = new NodeMemoryConfig()
Expand All @@ -65,7 +65,7 @@ public void testExplicitPropertyMappings()
.setSoftMaxQueryTotalMemoryPerNode(new DataSize(2, GIGABYTE))
.setHeapHeadroom(new DataSize(1, GIGABYTE))
.setReservedPoolEnabled(false)
.setVerboseExceededMemoryLimitErrorsEnabled(true);
.setVerboseExceededMemoryLimitErrorsEnabled(false);

assertFullMapping(properties, expected);
}
Expand All @@ -81,7 +81,7 @@ public void testOutOfRangeBroadcastMemoryLimit()
.put("query.soft-max-total-memory-per-node", "2GB")
.put("memory.heap-headroom-per-node", "1GB")
.put("experimental.reserved-pool-enabled", "false")
.put("memory.verbose-exceeded-memory-limit-errors-enabled", "true")
.put("memory.verbose-exceeded-memory-limit-errors-enabled", "false")
.build();

NodeMemoryConfig expected = new NodeMemoryConfig()
Expand All @@ -92,7 +92,7 @@ public void testOutOfRangeBroadcastMemoryLimit()
.setSoftMaxQueryTotalMemoryPerNode(new DataSize(2, GIGABYTE))
.setHeapHeadroom(new DataSize(1, GIGABYTE))
.setReservedPoolEnabled(false)
.setVerboseExceededMemoryLimitErrorsEnabled(true);
.setVerboseExceededMemoryLimitErrorsEnabled(false);

assertFullMapping(properties, expected);
}
Expand Down