Merged
Conversation
pranjalssh
force-pushed
the
create-type
branch
3 times, most recently
from
eaf52f0 to
5fbfdf8
Compare
rongrong
reviewed
Jul 6, 2021
presto-parser/src/main/java/com/facebook/presto/sql/tree/CreateType.java
Outdated
Show resolved
Hide resolved
rongrong
reviewed
Jul 6, 2021
Contributor
rongrong
left a comment
rongrong
left a comment
There was a problem hiding this comment.
Looks good in general. Please fix check style error and other tests.
presto-tests/src/test/java/com/facebook/presto/tests/TestSqlFunctions.java
Outdated
Show resolved
Hide resolved
presto-tests/src/test/java/com/facebook/presto/tests/TestSqlFunctions.java
Outdated
Show resolved
Hide resolved
pranjalssh
force-pushed
the
create-type
branch
2 times, most recently
from
0612be6 to
8fb0a70
Compare
Contributor
Author
|
Addressed comments |
rongrong
reviewed
Jul 10, 2021
presto-tests/src/test/java/com/facebook/presto/tests/TestSqlFunctions.java
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
We should probably have a separate TestUserDefinedTypes class for all tests related to types?
presto-parser/src/main/java/com/facebook/presto/sql/tree/CreateType.java
Outdated
Show resolved
Hide resolved
presto-parser/src/main/java/com/facebook/presto/sql/tree/CreateType.java
Outdated
Show resolved
Hide resolved
presto-tests/src/test/java/com/facebook/presto/tests/TestSqlFunctions.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/execution/CreateTypeTask.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Addressed comments |
pranjalssh
force-pushed
the
create-type
branch
2 times, most recently
from
981fca2 to
ecbd455
Compare
rongrong
approved these changes
Jul 20, 2021
Contributor
rongrong
left a comment
rongrong
left a comment
There was a problem hiding this comment.
Looks good. Just some nits regarding static imports. Thanks!
presto-main/src/main/java/com/facebook/presto/execution/CreateTypeTask.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/execution/CreateTypeTask.java
Outdated
Show resolved
Hide resolved
presto-parser/src/main/java/com/facebook/presto/sql/parser/AstBuilder.java
Outdated
Show resolved
Hide resolved
rongrong
reviewed
Jul 20, 2021
presto-main/src/main/java/com/facebook/presto/execution/CreateTypeTask.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Addressed comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support CREATE TYPE syntax. Currently, it only works for row types, and not for distinct types.
For #16324