Skip to content

Display coordinator host name in web ui#16254

Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom
abhiseksaikia:fireball_ui
Jun 21, 2021
Merged

Display coordinator host name in web ui#16254
tdcmeehan merged 1 commit intoprestodb:masterfrom
abhiseksaikia:fireball_ui

Conversation

@abhiseksaikia
Copy link
Contributor

@abhiseksaikia abhiseksaikia commented Jun 11, 2021

Now that all queries are collectively displayed in the coordinator web UI, regardless of which coordinator we choose to look at, we should also add the coordinator the query is running on, as a diagnostic for troubleshooting.

Test plan -
Tested by running in local
image

== RELEASE NOTES ==

General Changes
*  Display coordinator host name in web ui to support multi coordinator setup.

Copy link
Contributor

@swapsmagic swapsmagic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tdcmeehan
Copy link
Contributor

LGTM % I think we should be showing the node ID, not the IP address, as hosts can in theory come and go, however the ndoe ID shows the logic mapping of which process was assigned.

@abhiseksaikia
Copy link
Contributor Author

LGTM % I think we should be showing the node ID, not the IP address, as hosts can in theory come and go, however the ndoe ID shows the logic mapping of which process was assigned.

Thanks Tim! This is a great point that host can come and go. Only caveat of adding node ID is that currently this information is not available with query info. So we have to introduce a new field in query info which we want to avoid here.

@tdcmeehan
Copy link
Contributor

Looks like there's a merge conflict. LGTM otherwise

@abhiseksaikia
Copy link
Contributor Author

Rebase and fixed merge conflict

@tdcmeehan tdcmeehan self-assigned this Jun 17, 2021
@tdcmeehan tdcmeehan merged commit 43a656e into prestodb:master Jun 21, 2021
@ajaygeorge ajaygeorge mentioned this pull request Jul 7, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants