Display coordinator host name in web ui#16254
Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom Jun 21, 2021
Merged
Conversation
2c78015 to
28e091f
Compare
Contributor
|
LGTM % I think we should be showing the node ID, not the IP address, as hosts can in theory come and go, however the ndoe ID shows the logic mapping of which process was assigned. |
Contributor
Author
Thanks Tim! This is a great point that host can come and go. Only caveat of adding node ID is that currently this information is not available with query info. So we have to introduce a new field in query info which we want to avoid here. |
tdcmeehan
approved these changes
Jun 14, 2021
Contributor
|
Looks like there's a merge conflict. LGTM otherwise |
28e091f to
86467e9
Compare
Contributor
Author
|
Rebase and fixed merge conflict |
86467e9 to
6d227fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that all queries are collectively displayed in the coordinator web UI, regardless of which coordinator we choose to look at, we should also add the coordinator the query is running on, as a diagnostic for troubleshooting.
Test plan -

Tested by running in local