Add flags to disable spill for distinct and order by aggregations#16250
Merged
rschlussel merged 2 commits intoprestodb:masterfrom Jun 14, 2021
Merged
Add flags to disable spill for distinct and order by aggregations#16250rschlussel merged 2 commits intoprestodb:masterfrom
rschlussel merged 2 commits intoprestodb:masterfrom
Conversation
methods should be lower camel case, and tests should begin with the word "test"
Queries can sometimes use more memory in distinct and order by aggregations when spill is enabled compared to when it isn't. Until this is fixed we want to be able to disable those features and still have other operator spilling happen.
rschlussel
changed the title
highker
approved these changes
Jun 14, 2021
viczhang861
approved these changes
Jun 14, 2021
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added flags to disable spilling for distinct and order by aggregations since with spill enabled, they can cause queries to use more memory than without spilling. Left the features enabled by default to maintain previous behavior.
Test plan - unit test