Skip to content

Allow multiple or missing Hive bucket files#16230

Closed
v-jizhang wants to merge 3 commits intoprestodb:masterfrom
v-jizhang:hive_multiple_missing_bucket_files
Closed

Allow multiple or missing Hive bucket files#16230
v-jizhang wants to merge 3 commits intoprestodb:masterfrom
v-jizhang:hive_multiple_missing_bucket_files

Conversation

@v-jizhang
Copy link
Contributor

Cherry-pick of trinodb/trino#822,
trinodb/trino#848 and
trinodb/trino#1375

Co-authored-by: David Phillips david@acz.org
Co-authored-by: Piotr Findeisen piotr.findeisen@gmail.com

== RELEASE NOTES ==

Hive Changes
* Allow multiple or missing Hive bucket files

v-jizhang and others added 3 commits June 8, 2021 18:01
Cherry-pick of trinodb/trino#822,
trinodb/trino#848 and
trinodb/trino#1375

Co-authored-by: David Phillips <david@acz.org>
Co-authored-by: Piotr Findeisen <piotr.findeisen@gmail.com>
@aweisberg aweisberg requested review from aweisberg and highker June 25, 2021 19:47
Copy link
Contributor

@aweisberg aweisberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you break apart the three commits so that they map to the original ones? It helps preserve the history and makes them easier to review.

@c21
Copy link

c21 commented Jul 19, 2021

Hi @v-jizhang - wondering do you have a plan to work on this PR soon? This might not be big impact internally in Facebook, but is important to allow open source Spark/Presto/Trino/Hive to write same bucket table, thanks.

@aweisberg
Copy link
Contributor

@v-jizhang if you break apart the three commits then I can prioritize this review and we can get it done :-)

@v-jizhang
Copy link
Contributor Author

Hi @v-jizhang - wondering do you have a plan to work on this PR soon? This might not be big impact internally in Facebook, but is important to allow open source Spark/Presto/Trino/Hive to write same bucket table, thanks.

Thanks for reminding. Working on it now.

@v-jizhang
Copy link
Contributor Author

Replaced by #16456.

@v-jizhang v-jizhang closed this Jul 21, 2021
@v-jizhang
Copy link
Contributor Author

@v-jizhang if you break apart the three commits then I can prioritize this review and we can get it done :-)

Done, please review #16456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants