Skip to content

Add query statistic cumulative total memory#16215

Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom
jbapple:total-memory
Jun 10, 2021
Merged

Add query statistic cumulative total memory#16215
tdcmeehan merged 1 commit intoprestodb:masterfrom
jbapple:total-memory

Conversation

@jbapple
Copy link
Contributor

@jbapple jbapple commented Jun 4, 2021

This statistic counts not just user memory, but also system memory.

Test plan - Ran the unit tests and check_webui.sh

== RELEASE NOTES ==

General Changes
* Add a new total cumulative memory statistic

Web UI
* Add cumulative total memory to the Memory and Resource Utilization Summary tables on the QueryDetail page.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 4, 2021

CLA Signed

The committers are authorized under a signed CLA.

  • ✅ Jim Apple (e08a6661b63446cf86b22a0ba56dcbf9fcfa9ed0)

@jbapple jbapple marked this pull request as ready for review June 7, 2021 18:09
Copy link
Contributor

@tdcmeehan tdcmeehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nit

This statistic counts not just user memory, but also system memory.
Copy link

@mayankgarg1990 mayankgarg1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tdcmeehan tdcmeehan self-requested a review June 9, 2021 14:42
@tdcmeehan tdcmeehan merged commit dd3e522 into prestodb:master Jun 10, 2021
@mayankgarg1990 mayankgarg1990 mentioned this pull request Jun 18, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants