Support parameters in lambda expressions for prepare statement#16184
Merged
highker merged 1 commit intoprestodb:masterfrom Jun 8, 2021
Merged
Support parameters in lambda expressions for prepare statement#16184highker merged 1 commit intoprestodb:masterfrom
highker merged 1 commit intoprestodb:masterfrom
Conversation
|
|
yuanzhanhku
force-pushed
the
second
branch
2 times, most recently
from
522f0c6 to
3518d58
Compare
highker
approved these changes
Jun 7, 2021
Comment on lines
5728
to
5742
Contributor
Author
There was a problem hiding this comment.
It is changed by the formatter automatically. The previous format seems incorrect because there is a + in the previous line.
presto-tests/src/main/java/com/facebook/presto/tests/AbstractTestQueries.java
Outdated
Show resolved
Hide resolved
...o-spark-base/src/test/java/com/facebook/presto/spark/TestPrestoSparkAbstractTestQueries.java
Outdated
Show resolved
Hide resolved
Comment on lines
60
to
61
There was a problem hiding this comment.
I think it is a legit change; but really would love to have @rschlussel to double check. If prepared statement is going to collect ? in sequence, this visitor shouldn't mess the sequence up or make any damage to the scope (which I assume parameters don't care about scopes).
rschlussel
reviewed
Jun 7, 2021
Contributor
rschlussel
left a comment
rschlussel
left a comment
There was a problem hiding this comment.
Thanks so much for fixing. Just fix the checkstyle errors, and this looks good.
Comment on lines
60
to
61
Override visitLambdaExpression in ParameterExtractingVisitor to support extracting parameters form lambda expressions. This commit does not add the override function to DefaultTraversalVisitor because there are other visitors which do not expect to visit lambdas. For example, VariablesExtractor doesn't want to extract variables from lambdas and treat it as dependencies from the source plan.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #16005
Override visitLambdaExpression in ParameterExtractingVisitor to support
extracting parameters form lambda expressions. This commit does not add the
override function to DefaultTraversalVisitor because there are other
visitors which do not expect to visit lambdas. For example,
VariablesExtractor doesn't want to extract variables from lambdas and
treat it as dependencies from the source plan.
Test plan