Skip to content

Fix Config Validation #16164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arhimondr merged 1 commit into from
Jun 1, 2021
Merged

Fix Config Validation #16164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion presto-main/src/main/java/com/facebook/presto/execution/TaskManagerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,14 +243,14 @@ public TaskManagerConfig setShareIndexLoading(boolean shareIndexLoading)
return this;
}

@Min(0)
public BigDecimal getLevelTimeMultiplier()
{
return levelTimeMultiplier;
}

@Config("task.level-time-multiplier")
@ConfigDescription("Factor that determines the target scheduled time for a level relative to the next")
@Min(0)
public TaskManagerConfig setLevelTimeMultiplier(BigDecimal levelTimeMultiplier)
{
this.levelTimeMultiplier = levelTimeMultiplier;
Expand Down
4 changes: 2 additions & 2 deletions presto-main/src/main/java/com/facebook/presto/sql/analyzer/FeaturesConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,13 +494,13 @@ public FeaturesConfig setMaxStageRetries(int maxStageRetries)
return this;
}

@Min(0)
public int getConcurrentLifespansPerTask()
{
return concurrentLifespansPerTask;
}

@Config("concurrent-lifespans-per-task")
@Min(0)
@ConfigDescription("Experimental: Default number of lifespans that run in parallel on each task when grouped execution is enabled")
// When set to zero, a limit is not imposed on the number of lifespans that run in parallel
public FeaturesConfig setConcurrentLifespansPerTask(int concurrentLifespansPerTask)
Expand Down Expand Up @@ -1307,14 +1307,14 @@ public boolean isPushLimitThroughOuterJoin()
}

@Config("max-concurrent-materializations")
@Min(1)
@ConfigDescription("The maximum number of materializing plan sections that can run concurrently")
public FeaturesConfig setMaxConcurrentMaterializations(int maxConcurrentMaterializations)
{
this.maxConcurrentMaterializations = maxConcurrentMaterializations;
return this;
}

@Min(1)
public int getMaxConcurrentMaterializations()
{
return maxConcurrentMaterializations;
Expand Down