Skip to content

Fix config validation (apply to 0.228) #16162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
darrenfu wants to merge 1 commit into from
Closed

Fix config validation (apply to 0.228) #16162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions presto-hive/src/main/java/com/facebook/presto/hive/HiveClientConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,53 +385,53 @@ public HiveClientConfig setAllowCorruptWritesForTesting(boolean allowCorruptWrit
return this;
}

@MinDuration("0ms")
@NotNull
public Duration getMetastoreCacheTtl()
{
return metastoreCacheTtl;
}

@MinDuration("0ms")
@Config("hive.metastore-cache-ttl")
public HiveClientConfig setMetastoreCacheTtl(Duration metastoreCacheTtl)
{
this.metastoreCacheTtl = metastoreCacheTtl;
return this;
}

@MinDuration("1ms")
@NotNull
public Duration getMetastoreRefreshInterval()
{
return metastoreRefreshInterval;
}

@MinDuration("1ms")
@Config("hive.metastore-refresh-interval")
public HiveClientConfig setMetastoreRefreshInterval(Duration metastoreRefreshInterval)
{
this.metastoreRefreshInterval = metastoreRefreshInterval;
return this;
}

@Min(1)
public long getMetastoreCacheMaximumSize()
{
return metastoreCacheMaximumSize;
}

@Min(1)
@Config("hive.metastore-cache-maximum-size")
public HiveClientConfig setMetastoreCacheMaximumSize(long metastoreCacheMaximumSize)
{
this.metastoreCacheMaximumSize = metastoreCacheMaximumSize;
return this;
}

@Min(1)
public long getPerTransactionMetastoreCacheMaximumSize()
{
return perTransactionMetastoreCacheMaximumSize;
}

@Min(1)
@Config("hive.per-transaction-metastore-cache-maximum-size")
public HiveClientConfig setPerTransactionMetastoreCacheMaximumSize(long perTransactionMetastoreCacheMaximumSize)
{
Expand Down
2 changes: 1 addition & 1 deletion presto-main/src/main/java/com/facebook/presto/execution/TaskManagerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,14 +215,14 @@ public TaskManagerConfig setShareIndexLoading(boolean shareIndexLoading)
return this;
}

@Min(0)
public BigDecimal getLevelTimeMultiplier()
{
return levelTimeMultiplier;
}

@Config("task.level-time-multiplier")
@ConfigDescription("Factor that determines the target scheduled time for a level relative to the next")
@Min(0)
public TaskManagerConfig setLevelTimeMultiplier(BigDecimal levelTimeMultiplier)
{
this.levelTimeMultiplier = levelTimeMultiplier;
Expand Down
4 changes: 2 additions & 2 deletions presto-main/src/main/java/com/facebook/presto/sql/analyzer/FeaturesConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,13 +394,13 @@ public FeaturesConfig setMaxFailedTaskPercentage(double maxFailedTaskPercentage)
return this;
}

@Min(0)
public int getConcurrentLifespansPerTask()
{
return concurrentLifespansPerTask;
}

@Config("concurrent-lifespans-per-task")
@Min(0)
@ConfigDescription("Experimental: Default number of lifespans that run in parallel on each task when grouped execution is enabled")
// When set to zero, a limit is not imposed on the number of lifespans that run in parallel
public FeaturesConfig setConcurrentLifespansPerTask(int concurrentLifespansPerTask)
Expand Down Expand Up @@ -1026,14 +1026,14 @@ public boolean isPushLimitThroughOuterJoin()
}

@Config("max-concurrent-materializations")
@Min(1)
@ConfigDescription("The maximum number of materializing plan sections that can run concurrently")
public FeaturesConfig setMaxConcurrentMaterializations(int maxConcurrentMaterializations)
{
this.maxConcurrentMaterializations = maxConcurrentMaterializations;
return this;
}

@Min(1)
public int getMaxConcurrentMaterializations()
{
return maxConcurrentMaterializations;
Expand Down