Fix the import of SMALLINT in ParquetReader#16152
Merged
vkorukanti merged 1 commit intoprestodb:masterfrom May 26, 2021
Merged
Conversation
Contributor
|
@chliang71 Thanks for fixing this. Could you please add a unitest in this test suite? |
Contributor
Author
I added a test in AbstractTestParquetReader. The test fails without the fix, and succeeded with the fix. Thanks. |
chliang71
force-pushed
the
chliang-smallint-import
branch
from
0f480c6 to
e48f7a3
Compare
vkorukanti
approved these changes
May 25, 2021
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently Parquet imports SMALLINT from
com.facebook.presto.common.type.StandardTypes.SMALLINTThis is a string "SMALLINT", the expected type here is actually a SMALLINT type object. Namely:
com.facebook.presto.common.type.SmallintType.SMALLINTcc. @vkorukanti do you mind taking a look?