Support spilling for Presto on Spark#16133
Merged
arhimondr merged 6 commits intoprestodb:masterfrom May 20, 2021
Merged
Conversation
viczhang861
force-pushed
the
pos_spill_push
branch
from
250de6c to
1d40c9a
Compare
Contributor
Author
|
There is one flaky test |
viczhang861
commented
May 20, 2021
presto-spark-base/src/main/java/com/facebook/presto/spark/PrestoSparkConfig.java
Outdated
Show resolved
Hide resolved
presto-spark-base/src/main/java/com/facebook/presto/spark/PrestoSparkModule.java
Outdated
Show resolved
Hide resolved
presto-spark-base/src/main/java/com/facebook/presto/spark/PrestoSparkSessionProperties.java
Outdated
Show resolved
Hide resolved
...k-base/src/main/java/com/facebook/presto/spark/execution/PrestoSparkTaskExecutorFactory.java
Outdated
Show resolved
Hide resolved
...k-base/src/main/java/com/facebook/presto/spark/execution/PrestoSparkTaskExecutorFactory.java
Outdated
Show resolved
Hide resolved
...o-spark-base/src/test/java/com/facebook/presto/spark/TestPrestoSparkSpilledAggregations.java
Outdated
Show resolved
Hide resolved
presto-spark-base/src/main/java/com/facebook/presto/spark/PrestoSparkConfig.java
Outdated
Show resolved
Hide resolved
...k-base/src/main/java/com/facebook/presto/spark/execution/PrestoSparkTaskExecutorFactory.java
Outdated
Show resolved
Hide resolved
...k-base/src/main/java/com/facebook/presto/spark/execution/PrestoSparkTaskExecutorFactory.java
Outdated
Show resolved
Hide resolved
Revocalbe memory should be counted towards total used memory for Presto on Spark query.
Add revocable memory to node total memory for Presto on Spark query only.
Tuning memory revoking threshold by session property is only allowed for Presto no Spark query.
viczhang861
force-pushed
the
pos_spill_push
branch
from
ecbb976 to
5eb6c8c
Compare
arhimondr
approved these changes
May 20, 2021
10 tasks
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR only makes spilling work, it is not targeted for memory improvement after enabling spilling.
Test
Enable spilling and manually verify spilled file is created.
Run large Presto on Spark query and verify data is spilled in logging.