Implement efficient way to fetch partition name and values#16129
Merged
highker merged 1 commit intoprestodb:masterfrom May 22, 2021
jzzhaofb-zz:modify-method
Merged
Implement efficient way to fetch partition name and values#16129highker merged 1 commit intoprestodb:masterfrom jzzhaofb-zz:modify-method
highker merged 1 commit intoprestodb:masterfrom
jzzhaofb-zz:modify-method
Conversation
|
|
Contributor
|
Can you please write few tests in the TestHiveUtils to verify it? |
Contributor
|
Commit messages should follow these guidelines (http://chris.beams.io/posts/git-commit/) |
jainxrohit
requested changes
May 20, 2021
Contributor
jainxrohit
left a comment
jainxrohit
left a comment
There was a problem hiding this comment.
Please also squash all commits in to one commit.
presto-hive-metastore/src/main/java/com/facebook/presto/hive/metastore/MetastoreUtil.java
Outdated
Show resolved
Hide resolved
presto-hive-metastore/src/main/java/com/facebook/presto/hive/metastore/MetastoreUtil.java
Outdated
Show resolved
Hide resolved
presto-hive-metastore/src/main/java/com/facebook/presto/hive/metastore/MetastoreUtil.java
Outdated
Show resolved
Hide resolved
presto-hive-metastore/src/main/java/com/facebook/presto/hive/metastore/MetastoreUtil.java
Outdated
Show resolved
Hide resolved
presto-hive-metastore/src/main/java/com/facebook/presto/hive/metastore/MetastoreUtil.java
Outdated
Show resolved
Hide resolved
Contributor
|
Use the commit message and PR title as |
jainxrohit
requested changes
May 20, 2021
presto-hive/src/test/java/com/facebook/presto/hive/TestHiveMaterializedViewUtils.java
Outdated
Show resolved
Hide resolved
presto-hive-metastore/src/main/java/com/facebook/presto/hive/metastore/MetastoreUtil.java
Outdated
Show resolved
Hide resolved
jzzhaofb-zz
changed the title
jainxrohit
requested changes
May 20, 2021
presto-hive/src/test/java/com/facebook/presto/hive/TestHiveUtil.java
Outdated
Show resolved
Hide resolved
presto-hive/src/test/java/com/facebook/presto/hive/TestHiveUtil.java
Outdated
Show resolved
Hide resolved
jainxrohit
requested changes
May 21, 2021
presto-hive/src/test/java/com/facebook/presto/hive/TestHiveUtil.java
Outdated
Show resolved
Hide resolved
jainxrohit
requested changes
May 21, 2021
presto-hive/src/test/java/com/facebook/presto/hive/TestHiveUtil.java
Outdated
Show resolved
Hide resolved
The character traversal approach for fetching partition name and values is more efficient than the regex approach.
highker
approved these changes
May 21, 2021
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.