Use searchInterruptible for Joni regexp matching

[kaikalur]

Joni regexp search can be very slow. This can cause runaway splits issue. So we use the searchInterruptible method so it can be interrupted in such cases.

Test plan - None

== RELEASE NOTES ==

General Changes
*  Fix an issue where regular expression functions were not interruptible and could  keep running for a long time after the query they were a part of failed. 

[aweisberg]

I tested this change from TaskExecutor and it seems to work reasonably well. I did find that it doesn't check interrupt on some regexes.

[kaikalur]

I tested this change from TaskExecutor and it seems to work reasonably well. I did find that it doesn't check interrupt on some regexes.

Hmm - can you repro reliably? Maybe some other function handled it already before it came to Joni?

[aweisberg]

It not always detecting interrupt is fine I just noticed that its contract is not guaranteed to throw. This means there are cases where it will execute the regex without ever checking for interrupt.

So for example you could call Thread.interrupt(), then searchInterruptible and it will complete normally.

[aweisberg]

Can you squash (fixup) the additional commit before it gets merged? Thanks!

[kaikalur]

Can you squash (fixup) the additional commit before it gets merged? Thanks!

Done

[aweisberg]

See added comment.

[aweisberg]

@highker suggested adding Options.DEFAULT directly here instead of passing it in since it is always the same.

[kaikalur]

Done

[rschlussel]

@kaikalur can you add to the test plan the manual testing you did that demonstrated that this was helpful.

[rschlussel]

also, this should probably get a release note, since it caused production issues.

[aweisberg]

I tested this with #16111 on this query 20210518_201931_00000_y9r9j
In theory this should also help with query timeouts (wall, CPU) and cancellation.

[kaikalur]

@kaikalur can you add to the test plan the manual testing you did that demonstrated that this was helpful.

See Ariel's response below. He tested it.

[rschlussel]

Just add a release note, and I'll merge this.

[kaikalur]

Just add a release note, and I'll merge this.

Done

[rschlussel]

I updated the release note to be more focused on the impact of the change. Feel free to fix it if it's not accurate.