Add properties to update memory in TableFinishOperator#16095
Merged
arhimondr merged 1 commit intoprestodb:masterfrom May 14, 2021
Merged
Add properties to update memory in TableFinishOperator#16095arhimondr merged 1 commit intoprestodb:masterfrom
arhimondr merged 1 commit intoprestodb:masterfrom
Conversation
arhimondr
approved these changes
May 13, 2021
Member
There was a problem hiding this comment.
nit: tableFinishOperatorMemoryTrackingEnabled (also get/set and the property name)
Member
There was a problem hiding this comment.
Ideally we shouldn't allow users disable memory tracking. Let's have it as a configuration property only.
Contributor
Author
There was a problem hiding this comment.
Good point, removed
When system memory used by TableFinishOperator is tracked and included in query total memory, query may hit memory limit and fail.
viczhang861
force-pushed
the
track_stats_memory
branch
from
2293480 to
cc8ac49
Compare
arhimondr
approved these changes
May 14, 2021
Contributor
Author
|
Facebook integration test actually passes : https://s-jenkinsv2-presto-fbinfra-net.silfra.facebook.net/job/presto-facebook-oss-integration-github/6444/console. |
10 tasks
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When system memory used by TableFinishOperator is tracked
and included in query total memory, query may hit memory
limit and fail.