Define custom json serializer for DataSize and Duration#16087
Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom May 13, 2021
Merged
Define custom json serializer for DataSize and Duration#16087tdcmeehan merged 1 commit intoprestodb:masterfrom
tdcmeehan merged 1 commit intoprestodb:masterfrom
Conversation
Currently thrift encoding leverages ThriftCodec implementations that convert datasize as well as duration to double for optimization. So even though resource manager thrift client sends both duration as well as data size with well formatted unit, the unit information is getting lost on Resource manager server. This commit is to address this issue by defining custom json serializer so that UI can display well formatted json value for DataSize and Duration.
tdcmeehan
approved these changes
May 13, 2021
10 tasks
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently thrift encoding leverages ThriftCodec implementations that convert DataSize as well as Duration objects to double for optimization. So even though the resource manager thrift client sends both DataSize as well as Duration objects with well formatted unit, the unit information is getting lost on Resource manager server side. This commit is to address this issue by defining custom json serializer so that UI can display well formatted json value for DataSize and Duration.
Test plan - Verified by running TpchQueryRunner