Improve memory usage in TableFinishOperator#16036
Merged
arhimondr merged 3 commits intoprestodb:masterfrom May 10, 2021
Merged
Conversation
Data in statistics pages is final for any completed task in non-recoverable mode.
The total memory for all statistics page could be large and cause full GC issue. Removing page that will not be accessed.
Column statistics and PartitionUpdate could be memory expensive, for example, in grouped execution.
viczhang861
changed the title
viczhang861
changed the title
arhimondr
approved these changes
May 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16022
Track column statistics only in recoverable modewill improve Presto on Spark driver memory as POS usesTASK_COMMITstrategy.Test plan
enable_stats_collection_for_temporary_table=true,hash_partition_count=16384to increase memory used for stats collection. Running shadow query for 24 hr, no full GC found in coordinator.