Fix cumulativeUserMemory initial calculation & use double for cumulativeUserMemory consistently#16026
Merged
arhimondr merged 1 commit intoprestodb:masterfrom Apr 30, 2021
Conversation
629daef to
20a71dd
Compare
arhimondr
approved these changes
Apr 30, 2021
…iveUserMemory consistently Signed-off-by: frankobe <mua08p@gmail.com>
20a71dd to
6f7b1b3
Compare
Contributor
Author
|
@arhimondr Thx 4 review. Would u mind merging it? I am not authorized to do so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is a chance that
Cumulative User Memoryis much larger thanPeak User Memory*Execution Time, refer to the following screenshot of one sample query:Extra debug logging in
TaskContext.javashows,The bug is that
sinceLastPeriodMilliscan equal to current system nano time if thelastTaskStatCallNanosis not initialized and defaults to 0.The fix is basically initialize the
lastTaskStatCallNanosto task start time.Signed-off-by: frankobe mua08p@gmail.com
Test plan - (Please fill in how you tested your changes)
Unit Test