Skip to content

Add max error retry config option to glue client #16018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arhimondr merged 1 commit into from
May 13, 2021
Merged

Add max error retry config option to glue client #16018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...ve-metastore/src/main/java/com/facebook/presto/hive/metastore/glue/GlueHiveMetastore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,9 @@ public GlueHiveMetastore(

private static AWSGlueAsync createAsyncGlueClient(GlueHiveMetastoreConfig config, RequestMetricCollector metricsCollector)
{
ClientConfiguration clientConfig = new ClientConfiguration().withMaxConnections(config.getMaxGlueConnections());
ClientConfiguration clientConfig = new ClientConfiguration()
.withMaxConnections(config.getMaxGlueConnections())
.withMaxErrorRetry(config.getMaxGlueErrorRetries());
AWSGlueAsyncClientBuilder asyncGlueClientBuilder = AWSGlueAsyncClientBuilder.standard()
.withMetricsCollector(metricsCollector)
.withClientConfiguration(clientConfig);
Expand Down
14 changes: 14 additions & 0 deletions ...astore/src/main/java/com/facebook/presto/hive/metastore/glue/GlueHiveMetastoreConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ public class GlueHiveMetastoreConfig
{
private Optional<String> glueRegion = Optional.empty();
private boolean pinGlueClientToCurrentRegion;
private int maxGlueErrorRetries = 10;
private int maxGlueConnections = 5;
private Optional<String> defaultWarehouseDir = Optional.empty();
private Optional<String> catalogId = Optional.empty();
Expand Down Expand Up @@ -72,6 +73,19 @@ public GlueHiveMetastoreConfig setMaxGlueConnections(int maxGlueConnections)
return this;
}

@Min(0)
public int getMaxGlueErrorRetries()
{
return maxGlueErrorRetries;
}

@Config("hive.metastore.glue.max-error-retries")
public GlueHiveMetastoreConfig setMaxGlueErrorRetries(int maxGlueErrorRetries)
{
this.maxGlueErrorRetries = maxGlueErrorRetries;
return this;
}

public Optional<String> getDefaultWarehouseDir()
{
return defaultWarehouseDir;
Expand Down
3 changes: 3 additions & 0 deletions ...re/src/test/java/com/facebook/presto/hive/metastore/glue/TestGlueHiveMetastoreConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ public void testDefaults()
.setGlueRegion(null)
.setPinGlueClientToCurrentRegion(false)
.setMaxGlueConnections(5)
.setMaxGlueErrorRetries(10)
.setDefaultWarehouseDir(null)
.setCatalogId(null)
.setPartitionSegments(5)
Expand All @@ -45,6 +46,7 @@ public void testExplicitPropertyMapping()
.put("hive.metastore.glue.region", "us-east-1")
.put("hive.metastore.glue.pin-client-to-current-region", "true")
.put("hive.metastore.glue.max-connections", "10")
.put("hive.metastore.glue.max-error-retries", "20")
.put("hive.metastore.glue.default-warehouse-dir", "/location")
.put("hive.metastore.glue.catalogid", "0123456789")
.put("hive.metastore.glue.partitions-segments", "10")
Expand All @@ -56,6 +58,7 @@ public void testExplicitPropertyMapping()
.setGlueRegion("us-east-1")
.setPinGlueClientToCurrentRegion(true)
.setMaxGlueConnections(10)
.setMaxGlueErrorRetries(20)
.setDefaultWarehouseDir("/location")
.setCatalogId("0123456789")
.setPartitionSegments(10)
Expand Down