Fix S3 directory detection based on ContentType header#16000
Merged
rschlussel merged 1 commit intoprestodb:masterfrom Apr 28, 2021
Merged
Fix S3 directory detection based on ContentType header#16000rschlussel merged 1 commit intoprestodb:masterfrom
rschlussel merged 1 commit intoprestodb:masterfrom
Conversation
Member
Author
|
@aweisberg : Can you please review this? |
Member
Author
|
@rschlussel : Can you please review or assign a reviewer? |
rschlussel
previously approved these changes
Apr 28, 2021
rschlussel
reviewed
Apr 28, 2021
Contributor
There was a problem hiding this comment.
It doesn't look like this ever gets used. Also, it would be great if we could have tests that check that it works both with and without the charset specified.
Member
Author
There was a problem hiding this comment.
This is used in testEmptyDirectory(). Will add test for without the charset in the string.
Member
Author
There was a problem hiding this comment.
@rschlussel : I have added the test for content type without charset too. Please have a look. Thanks!
Cherry pick of trinodb/trino#6992 Co-authored-by: Michał Ślizak <michal.slizak+github@gmail.com>
nmahadevuni
force-pushed
the
fix_s3_directory_check
branch
from
467b2c5 to
f0267c5
Compare
rschlussel
approved these changes
Apr 28, 2021
Contributor
|
Can you add a release note describing the use case that was fixed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick of trinodb/trino#6992
Co-authored-by: Michał Ślizak michal.slizak+github@gmail.com
Test plan - Added test in TestPrestoS3FileSystem