Merged
Conversation
Previously this value was set anytime it was present, even if spill was disabled, or for outer joins or probe only grouped execution.
SpilledLookupSourceHandle needs to be disposed immediately when join operators finished processing probe data. Otherwise SpilledLookupSourceHandle is never disposed as it's not registered in PartitionedConsumption. This prevents HashBuilderOperator from finishing. Fixes: prestodb#15542 co-authored-by: Karol Sobczak <napewnotrafi@gmail.com>
Reenable test that was hanging due to join spill issue.
test methods should all start with the word "test".
rschlussel
force-pushed
the
fix-hanging-join-test
branch
from
991d302 to
c97304f
Compare
arhimondr
approved these changes
Apr 20, 2021
highker
approved these changes
Apr 21, 2021
tdcmeehan
approved these changes
Apr 21, 2021
sachdevs
approved these changes
Apr 21, 2021
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan - unit test, ci
Cherry-pick of trinodb/trino@42b8e33 plus some required refactoring.
SpilledLookupSourceHandle needs to be disposed immediately when join operators finished processing probe data. Otherwise SpilledLookupSourceHandle is never disposed as it's not registered in PartitionedConsumption. This prevents HashBuilderOperator from finishing.
This was causing some tests to hang in TestDistributedSpilledQueries.
Fixes #15542 and #15921