Add support for static AWS credentials in GlueHiveMetastore#15950
Merged
highker merged 1 commit intoprestodb:masterfrom May 25, 2021
Merged
Add support for static AWS credentials in GlueHiveMetastore#15950highker merged 1 commit intoprestodb:masterfrom
highker merged 1 commit intoprestodb:masterfrom
Conversation
aweisberg
suggested changes
May 12, 2021
Contributor
aweisberg
left a comment
aweisberg
left a comment
There was a problem hiding this comment.
Can you try and also cherry-pick or add documentation at the same time? trinodb/trino@c1ac9ac
Our policy is to include documentation with changes instead of having them added (or not!) later :-)
Contributor
|
+1 other then the docs. You can keep the docs in a separate commit just include it in the PR. |
Contributor
Author
I'll document it in another PR. Thanks |
v-jizhang
force-pushed
the
aws_credentials
branch
from
9d05729 to
1bbf24d
Compare
Contributor
Author
|
Added docs. |
aweisberg
suggested changes
May 13, 2021
aweisberg
suggested changes
May 13, 2021
aweisberg
approved these changes
May 14, 2021
Contributor
aweisberg
left a comment
aweisberg
left a comment
There was a problem hiding this comment.
All checks were successful even the FB integration. I am going to squash the commits.
aweisberg
force-pushed
the
aws_credentials
branch
from
ac946fa to
85813b8
Compare
aweisberg
force-pushed
the
aws_credentials
branch
from
85813b8 to
400a995
Compare
Contributor
|
Rebased because of what looks like a bogus fb integration failure. It was a checkstyle violation that didn't seem to be present in the code. |
Cherry pick of trinodb/trino#748 This PR adds support for specifying static AWS credentials for GlueHiveMetastore through two new configuration options, hive.metastore.glue.aws-access-key and hive.metastore.glue.aws-secret-key. This is helpful in situations where someone may want to access a glue catalog through Presto without running the cluster on AWS infrastructure. Co-authored-by: Philippe Gagnon <pgagnon@users.noreply.github.com>
aweisberg
force-pushed
the
aws_credentials
branch
from
400a995 to
09f03d7
Compare
highker
approved these changes
May 25, 2021
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick of trinodb/trino#748
This PR adds support for specifying static AWS credentials for
GlueHiveMetastore through two new configuration options,
hive.metastore.glue.aws-access-key and
hive.metastore.glue.aws-secret-key.
This is helpful in situations where someone may want to access a glue
catalog through Presto without running the cluster on AWS
infrastructure.
Co-authored-by: Philippe Gagnon pgagnon@users.noreply.github.com