Skip to content

Fix memory leak in NodeTaskMap #15856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tdcmeehan merged 1 commit into from
Mar 22, 2021
Merged

Fix memory leak in NodeTaskMap #15856

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions presto-main/src/main/java/com/facebook/presto/execution/NodeTaskMap.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,13 @@ public NodeStatsTracker createTaskStatsTrackers(TaskId taskId)

// when nodeStatsTracker is garbage collected, run the cleanup method on the tracker
// Note: tracker can not have a reference to nodeStatsTracker
finalizerService.addFinalizer(nodeStatsTracker, splitTracker::cleanup);
finalizerService.addFinalizer(memoryUsageTracker, memoryUsageTracker::cleanup);
finalizerService.addFinalizer(cpuUtilizationPercentageTracker, cpuUtilizationPercentageTracker::cleanup);
// instances of TaskStatsTracker and AccumulatedTaskStatsTracker should not be passed for GC to
// help ensure that GC is actually invoked for nodeStatsTracker
finalizerService.addFinalizer(nodeStatsTracker, () -> {
Copy link
Copy Markdown
Contributor

@mbasmanova mbasmanova Mar 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps, add a comment explaining that this cannot be broken down into 3 separate finalizers as this is non-obvious

Copy link
Copy Markdown
Author

@mayankgarg1990 mayankgarg1990 Mar 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the necessary comment

splitTracker.cleanup();
memoryUsageTracker.cleanup();
cpuUtilizationPercentageTracker.cleanup();
});

return nodeStatsTracker;
}
Expand Down