Fix LocalExecutionPlan for IndexJoin when spill enabled#15773
Merged
rschlussel merged 1 commit intoprestodb:masterfrom Mar 5, 2021
Merged
Fix LocalExecutionPlan for IndexJoin when spill enabled#15773rschlussel merged 1 commit intoprestodb:masterfrom
rschlussel merged 1 commit intoprestodb:masterfrom
Conversation
Index join does not support spill, so we don't ensure that we add exchanges with fixed distribution before an index join. However, we were still checking for fixed distribution in the LocalExecutionPlanner. This removes the check for the number of operators since that is only needed for spill
sachdevs
approved these changes
Mar 4, 2021
Contributor
sachdevs
left a comment
sachdevs
left a comment
There was a problem hiding this comment.
Other than seemingly unrelated maven fail, LGTM
Contributor
Author
Yeah, just restarted the workflow. annoyingly for github actions you can't restart only the failed jobs, and you have to wait for the whole workflow to complete before you can restart. |
arhimondr
approved these changes
Mar 5, 2021
13 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Index join does not support spill, so we don't ensure that we add
exchanges with fixed distribution before an index join. However, we
were still checking for fixed distribution in the LocalExecutionPlanner.
This removes the check for the number of operators since that is only
needed for spill
Test plan - Added unit test