Skip to content

Allow to extend Kafka connector #15738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tdcmeehan merged 1 commit into from
Mar 20, 2021
Merged

Allow to extend Kafka connector #15738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion presto-kafka/src/main/java/com/facebook/presto/kafka/KafkaConnectorFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import com.facebook.presto.spi.connector.ConnectorContext;
import com.facebook.presto.spi.connector.ConnectorFactory;
import com.google.inject.Injector;
import com.google.inject.Module;
import com.google.inject.Scopes;
import com.google.inject.TypeLiteral;

Expand All @@ -39,10 +40,12 @@
public class KafkaConnectorFactory
implements ConnectorFactory
{
private final Module extension;
private final Optional<Supplier<Map<SchemaTableName, KafkaTopicDescription>>> tableDescriptionSupplier;

KafkaConnectorFactory(Optional<Supplier<Map<SchemaTableName, KafkaTopicDescription>>> tableDescriptionSupplier)
KafkaConnectorFactory(Module extension, Optional<Supplier<Map<SchemaTableName, KafkaTopicDescription>>> tableDescriptionSupplier)
{
this.extension = requireNonNull(extension, "extension is null");
this.tableDescriptionSupplier = requireNonNull(tableDescriptionSupplier, "tableDescriptionSupplier is null");
}

Expand All @@ -68,6 +71,7 @@ public Connector create(String catalogName, Map<String, String> config, Connecto
Bootstrap app = new Bootstrap(
new JsonModule(),
new KafkaConnectorModule(),
extension,
binder -> {
binder.bind(KafkaConnectorId.class).toInstance(new KafkaConnectorId(catalogName));
binder.bind(TypeManager.class).toInstance(context.getTypeManager());
Expand Down
15 changes: 14 additions & 1 deletion presto-kafka/src/main/java/com/facebook/presto/kafka/KafkaPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
import com.facebook.presto.spi.connector.ConnectorFactory;
import com.google.common.annotations.VisibleForTesting;
import com.google.common.collect.ImmutableList;
import com.google.inject.Module;
import com.google.inject.util.Modules;

import java.util.Map;
import java.util.Optional;
Expand All @@ -31,8 +33,19 @@
public class KafkaPlugin
implements Plugin
{
private final Module extension;
private Optional<Supplier<Map<SchemaTableName, KafkaTopicDescription>>> tableDescriptionSupplier = Optional.empty();

public KafkaPlugin()
{
this(Modules.EMPTY_MODULE);
}

public KafkaPlugin(Module extension)
{
this.extension = requireNonNull(extension, "extension is null");
}

@VisibleForTesting
public synchronized void setTableDescriptionSupplier(Supplier<Map<SchemaTableName, KafkaTopicDescription>> tableDescriptionSupplier)
{
Expand All @@ -42,6 +55,6 @@ public synchronized void setTableDescriptionSupplier(Supplier<Map<SchemaTableNam
@Override
public synchronized Iterable<ConnectorFactory> getConnectorFactories()
{
return ImmutableList.of(new KafkaConnectorFactory(tableDescriptionSupplier));
return ImmutableList.of(new KafkaConnectorFactory(extension, tableDescriptionSupplier));
}
}