Support Trino bitwise shift functions in Presto#15730
Support Trino bitwise shift functions in Presto#15730mbasmanova merged 1 commit intoprestodb:masterfrom
Conversation
|
@Lewuathe appears to be the original author of this code. Please add them as a co-author. See our attribution guidelines. |
c0f3961 to
2582e96
Compare
Done. |
2582e96 to
469c0d0
Compare
Thanks for pointing that out - - I just rebased on tip master and force-pushed, so that should fix it. |
mbasmanova
left a comment
There was a problem hiding this comment.
@djsstarburst Would you add documentation for these functions?
469c0d0 to
8b90dc3
Compare
@mbasmanova, I added documentation and examples for the new shift functions in bitwise.rst. While I was at it, I fixed the broken formatting in the examples of the previously existing shift functions. |
To promote convergence between Trino and Presto, this commit adds to Presto the bitwise functions present in Trino but missing in Presto. Co-authored-by: Lewuathe <lewuathe@me.com>
8b90dc3 to
cfb9b53
Compare
|
@mbasmanova I restarted it and it looks like it is passing this time. |
|
@djsstarburst Thank you, David, for the contribution. Thanks @aweisberg for restarting a failing job. |
To promote convergence between Trino and Presto, this commit
adds to Presto the bitwise functions present in Trino but missing
in Presto.
Test plan - Appropriate tests have been added to class TestBitwiseFunctions as part of this commit.
== RELEASE NOTES ==
General Changes