Support correlated column mapping type coercion#15575
Merged
rschlussel merged 1 commit intoprestodb:masterfrom Jun 24, 2021
Merged
Support correlated column mapping type coercion#15575rschlussel merged 1 commit intoprestodb:masterfrom
rschlussel merged 1 commit intoprestodb:masterfrom
Conversation
fgwang7w
force-pushed
the
15574
branch
3 times, most recently
from
ba5df77 to
51ef5da
Compare
rschlussel
reviewed
Jan 6, 2021
presto-main/src/test/java/com/facebook/presto/sql/query/TestSubqueries.java
Outdated
Show resolved
Hide resolved
...m/facebook/presto/sql/planner/iterative/rule/TransformCorrelatedScalarAggregationToJoin.java
Outdated
Show resolved
Hide resolved
...o-main/src/main/java/com/facebook/presto/sql/planner/optimizations/PlanNodeDecorrelator.java
Outdated
Show resolved
Hide resolved
...o-main/src/main/java/com/facebook/presto/sql/planner/optimizations/PlanNodeDecorrelator.java
Outdated
Show resolved
Hide resolved
fgwang7w
force-pushed
the
15574
branch
2 times, most recently
from
82098f8 to
505c6bc
Compare
Member
Author
|
@rschlussel when you have a chance, could you please give another round review this fix? Prior review comments have been resolved. Many thanks |
Contributor
|
@rschlussel Could you please help to review this PR further? |
Member
Author
|
@rschlussel could you please help to have another look? This feature will lift some decorrelation restrictions. thanks |
Contributor
|
@rschlussel Do you think you can review this PR further? This issue resurfaced again at #16010 with Trino distraction. |
Contributor
|
sorry for delay. will review |
rschlussel
reviewed
Jun 10, 2021
...o-main/src/main/java/com/facebook/presto/sql/planner/optimizations/PlanNodeDecorrelator.java
Outdated
Show resolved
Hide resolved
...o-main/src/main/java/com/facebook/presto/sql/planner/optimizations/PlanNodeDecorrelator.java
Outdated
Show resolved
Hide resolved
rschlussel
reviewed
Jun 16, 2021
...o-main/src/main/java/com/facebook/presto/sql/planner/optimizations/PlanNodeDecorrelator.java
Outdated
Show resolved
Hide resolved
...o-main/src/main/java/com/facebook/presto/sql/planner/optimizations/PlanNodeDecorrelator.java
Outdated
Show resolved
Hide resolved
rschlussel
reviewed
Jun 21, 2021
...o-main/src/main/java/com/facebook/presto/sql/planner/optimizations/PlanNodeDecorrelator.java
Outdated
Show resolved
Hide resolved
...o-main/src/main/java/com/facebook/presto/sql/planner/optimizations/PlanNodeDecorrelator.java
Outdated
Show resolved
Hide resolved
rschlussel
reviewed
Jun 22, 2021
presto-main/src/test/java/com/facebook/presto/sql/query/TestSubqueries.java
Outdated
Show resolved
Hide resolved
presto-main/src/test/java/com/facebook/presto/sql/query/TestSubqueries.java
Outdated
Show resolved
Hide resolved
presto-main/src/test/java/com/facebook/presto/sql/query/TestSubqueries.java
Outdated
Show resolved
Hide resolved
fgwang7w
force-pushed
the
15574
branch
2 times, most recently
from
f6dcebc to
f1f5d10
Compare
Member
Author
|
Hi @rschlussel all comments are resolved for this PR, could you please kindly take a look again? many thanks |
rschlussel
approved these changes
Jun 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds type coercion support when correlated symbols are in non-direct column reference type.
Test plan -
Test in local, add UT coverage
resolve #15574